Skip to content

Make a release that includes the fix for validation of default enum values #180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
leoyvens opened this issue Dec 11, 2020 · 4 comments
Closed

Make a release that includes the fix for validation of default enum values #180

leoyvens opened this issue Dec 11, 2020 · 4 comments
Assignees
@Cito
Labels
type: bug An issue or pull request relating to a bug

Comments

@leoyvens
Copy link

I believe the fix of graphql-python/graphql-core#111 is needed for queries that rely on default enum values to be correctly validated. If you could kindly release a version of this package that includes that fix, that would be much appreciated.
@leszekhanusz
Copy link
Collaborator

We would need a new release of graphql-core first.

@leszekhanusz leszekhanusz added type: bug An issue or pull request relating to a bug status: blocked Issues outside of ggl control, caused by dependencies or something else labels Dec 11, 2020
LefterisJP added a commit to LefterisJP/rotkehlchen that referenced this issue Dec 11, 2020
@LefterisJP
Temporary fix for TheGraph's subgraphs and GraphQl rotki#180
e774e87 
graphql-python/gql#180
@LefterisJP
Copy link

We (https://github.com/rotki/rotki) would love to see a fix for this. We ran into this last night. I understand it's blocked until a new release of graphql-core is ready. Let us know if we can do anything to push it forward.

LefterisJP added a commit to rotki/rotki that referenced this issue Dec 12, 2020
@LefterisJP
Temporary fix for TheGraph's subgraphs and GraphQl #180
3d12b37 
graphql-python/gql#180
@leszekhanusz leszekhanusz removed the status: blocked Issues outside of ggl control, caused by dependencies or something else label Feb 9, 2021
@leszekhanusz
Copy link
Collaborator

This should be fixed by installing the graphql-core version 3.1.3
No new release of gql is needed as this fits the gql dependencies (graphql-core>=3.1,<3.2)

Thanks @Cito

@LefterisJP
Copy link

Thanks guys. We will try it.

@LefterisJP LefterisJP mentioned this issue Feb 13, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Cito Cito

Labels
type: bug An issue or pull request relating to a bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@Cito @LefterisJP @leszekhanusz @leoyvens