Add @GuardedBy and remove redundant synchronized #105
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbakerman
reviewed
Nov 17, 2021
| @@ -296,15 +298,12 @@ private void possiblyClearCacheEntriesOnExceptions(List<K> keys) { | |||
| return futureCache.get(cacheKey); | |||
| } | |||
|
|
|||
| CompletableFuture<V> loadCallFuture; | |||
| synchronized (dataLoader) { | |||
There was a problem hiding this comment.
This is a weird PR because you gave no explanation of why this synchronised call is not needed.
Are you sayin that a synchronized is already in place when this is called??
the loader queue is the key bit of mutable state in the DataLoader (the list of promises to get data at some future batch time) and hence needs synchronization of some sort.
There was a problem hiding this comment.
My point is - explanation is important
There was a problem hiding this comment.
@bbakerman Thanks for your response.
Yes. As @GuardedBy("dataLoader") describe, the thread is already hold dataLoader lock when loadFromCache is called.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As
@GuardedBy("dataLoader")describe, the thread is already holddataLoaderlock whenloadFromCacheis called.java-dataloader/src/main/java/org/dataloader/DataLoaderHelper.java
Line 102 in 4253050