Skip to content

invalid automatic module name when used with Java modules #101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
AutomatedTester opened this issue Aug 31, 2021 · 0 comments · Fixed by #104
Closed

invalid automatic module name when used with Java modules #101

AutomatedTester opened this issue Aug 31, 2021 · 0 comments · Fixed by #104

Comments

@AutomatedTester
Copy link

Describe the bug
When building Selenium with latest we are getting an invalid Automatic-Module-Name: com.graphql-java in the manifest.

There are two problems with that:

  • The project is dataloader, not graphql itself.
  • Module names need to be valid package names, and a dash character isn’t allowed

The better name is probably something like com.graphql.dataloader or similar

To get around this you just need to update gradle config to do what the Gradle docs suggests

To Reproduce
Update https://github.com/SeleniumHQ/selenium/blob/e92b16f0832da62204bda5d01fbc430ec9401deb/java/maven_deps.bzl to latest.

And then run bazel build grid in a terminal

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant