Skip to content

Adding Lists support for @NotBlank validation directive #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 6, 2021

Conversation

setchy
Copy link
Collaborator

@setchy setchy commented Feb 20, 2021

#31 @pelletier197 - would appreciate a review

@pelletier197
Copy link
Contributor

That looks like it solves like it solves the issue! Thank you 🙂

I actually implemented something on my side that adds support to all validators with lists by wrapping them. If the input element is a list, simply call the real one with each element of the list.

I could try to see if I can make it work with the project if you're interested, when I'll have time.

@setchy
Copy link
Collaborator Author

setchy commented Feb 20, 2021

Sure - a PR for other validation directives would be helpful

@setchy setchy requested review from bbakerman and andimarek April 10, 2021 12:32
@setchy setchy merged commit 471f544 into graphql-java:master May 6, 2021
@setchy setchy deleted the issue-31-notblank-list branch May 6, 2021 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants