Skip to content

Issue upgrading to GraphQL-java 19.1 #73

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
pelletier197 opened this issue Aug 23, 2022 · 3 comments
Closed

Issue upgrading to GraphQL-java 19.1 #73

pelletier197 opened this issue Aug 23, 2022 · 3 comments

Comments

@pelletier197
Copy link
Contributor

Describe the bug
Directives were changed to AppliedDirective in GraphQL 19.1 it seems, which skips validations completely. Switching to AppliedDirective today seemed to have no impact at all. See #72

To Reproduce
Upgrade to java-graphql 19.1, and normally all directives will fail to validate.

@pelletier197 pelletier197 changed the title Issue with GraphQL-java 19.1 Issue upgrading to GraphQL-java 19.1 Aug 23, 2022
@enriquedacostacambio
Copy link

enriquedacostacambio commented Sep 8, 2022

are you using graphql-java-tools? if so, i think the issue may happen due to upgrading that library rather than graphql-java.
see: graphql-java-kickstart/graphql-java-tools#695

Either way, upgrading graphql-java-extended-validation to use applied directives instead of old style ones bypasses this issue. +1 on you pr.

@pelletier197
Copy link
Contributor Author

Only missing a release of the library to fix the problem. Although I think it would be important to upgrade the library to use GraphQL version 19 as well.

@dondonz
Copy link
Member

dondonz commented Nov 13, 2022

Closing as #72 has been merged.

@dondonz dondonz closed this as completed Nov 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants