Skip to content

fix(local-date-time): fixes #7 add java.time.LocalDateTime support #107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

bhaskar-anil
Copy link

@bhaskar-anil bhaskar-anil commented May 28, 2023

This fixes #7
This would allow using java.time.LocalDateTime as graphql scalars, as:
scalar LocalDateTime
The value is formatted into a convenient and readable format of YYYY-MM-DD hh:mm:ss.

@bhaskar-anil bhaskar-anil changed the title feat(local-date-time): fixes #7 add java.time.LocalDateTime support fix(local-date-time): fixes #7 add java.time.LocalDateTime support May 28, 2023
@dondonz
Copy link
Member

dondonz commented Jan 2, 2024

Hello, I'm sorry it has taken a very long time to reply back.

Thanks for taking the initiative to open this PR.

As I mentioned in this comment #26 (comment), we previously decided not to include a LocalDateTime scalar because it doesn't specify the time offset. However, thanks very much for opening a PR!

@dondonz dondonz closed this Jan 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Proposal: LocalDateTime scalar
2 participants