Skip to content
This repository was archived by the owner on Dec 19, 2023. It is now read-only.

Websocket support #95

Merged
merged 15 commits into from
Jul 24, 2018
Merged

Websocket support #95

merged 15 commits into from
Jul 24, 2018

Conversation

oliemansm
Copy link
Member

I've merged in all latest changes and added a working example for subscriptions. Can you review so we can merge this one and release it? I haven't updated the version number of this one yet I believe.

@oliemansm oliemansm requested a review from apottere July 21, 2018 14:35
@oliemansm
Copy link
Member Author

graphql-java-servlet needs to be merged (and released) first before this one can successfully be released. It depends on the new graphl-java-servlet version 6.0.0.

This will allow for future updates to that response type, e.g. in line
with (ResultActions)[https://docs.spring.io/spring-framework/docs/current/javadoc-api/org/springframework/test/web/servlet/ResultActions.html]. This will allow more fluid checks of the json
response instead of having to manually traverse the `JsonNode` tree.
The only reason for this return object at this stage is to prepare the
public API for those additional features in the future.
@apottere
Copy link
Collaborator

@oliemansm graphql-java-servlet 6.0.0 is syncing now, it can take a while for it to show up though: https://search.maven.org/#search%7Cgav%7C1%7Cg%3A%22com.graphql-java%22%20AND%20a%3A%22graphql-java-servlet%22

@oliemansm oliemansm merged commit 0184c4e into master Jul 24, 2018
@apottere apottere deleted the websocket-support branch July 25, 2018 13:52
@apottere
Copy link
Collaborator

@oliemansm I'm going to release 6.1.0 of graphql-java-servlet real quick to pick up graphql-java-kickstart/graphql-java-servlet@e932a55 before releasing this

@apottere
Copy link
Collaborator

Released in 5.0.0!

@oliemansm
Copy link
Member Author

Thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants