Exclude overlap in dependency jars #255
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Exclude overlapping classes in jar files
|
@IceBlizz6 That is indeed the more important issue to fix, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@oliemansm
Hello again, sry that i haven't been responsive lately after the last pull request.
Work got chaotic after the COVID situation.
I would like to present a more immediate fix to the underlying problem in this pull request.
The goal of this PR is not to make the project itself into modules, but rather to make it compatible with the module system.
Projects that are not made into modules can still be used by modules because they will normally be converted into automatic modules.
With graphql-java-servlet this is not possible (atleast not without heavy configuration) because of the overlapping classes/packages in the jar files that throw this process off.
#244
I go into details here on how the problem looks like with the current jar files and how this bnd edit will resolve conflicting packages.
I originally wanted to take it one step further (making this project itself into modules), but for the short term we should focus on making it compatible.