Skip to content

Defer support #200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Sep 25, 2019
Merged

Defer support #200

merged 5 commits into from
Sep 25, 2019

Conversation

JacobMountain
Copy link
Contributor

An initial attempt at adding @defer directive support #133. Similar to the apollo spec, although currently without the specified line ending CRLF + "-----" + CRLF . I still have to integration test this.

Additional Links

  1. GraphQLJava @defer example

@JacobMountain
Copy link
Contributor Author

I'm not sure if apollo client currently has @defer support. Waiting on apollographql/apollo-feature-requests#3

@oliemansm oliemansm merged commit 4934616 into graphql-java-kickstart:master Sep 25, 2019
@oliemansm
Copy link
Member

@JacobMountain The defer tests are failing for me. I've marked them ignore for now. Can't imagine they are working for you. Any idea what's going on?

@JacobMountain
Copy link
Contributor Author

@oliemansm very interesting, I just triple checked my feature branch and they were working still. I will have a look on develop

@JacobMountain
Copy link
Contributor Author

@oliemansm why are the original async request tests ignored too? maybe the problem is related

@oliemansm
Copy link
Member

@JacobMountain Not sure actually... But probably is related, yes. Will try them later as well, but if you have any idea what's wrong that would be helpful :)

@oliemansm
Copy link
Member

@JacobMountain Found something. It's a recent PR that got merged that serializes directly to the writer, but that closes something apparently leading to the next elements not being serialized correctly. Problem was in the onNext of the ExecutioNResultSubscriber that was changed.

Probably still issues with async, but at least part of it is solved now.

@oliemansm oliemansm added this to the 8.1.0 milestone Nov 16, 2019
@oliemansm oliemansm modified the milestones: 8.1.0, 9.0.0 Nov 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants