Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #60
This PR provides simplifies the construction of the GraphQL Servlet and provides an alternative way as well through the proposed
getConfiguration()
method.To create a new servlet you have two options. If you just want to use default settings and expose a schema use
GraphQLHttpServlet.with(graphqlSchema)
.If you want to control all the options use
GraphQLHttpServlet.with(graphqlConfiguration)
. The configuration basically is the replacement for the Builder with the same functionality.As per the suggestion in #60 you can also subclass
GraphQLHttpServlet
and override thegetConfiguration()
method as follows.For now the previous functionality has been deprecated. So no breaking changes yet.