Skip to content

Allow timeout to be set when asyncServletModeEnabled=true #184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
kclaes opened this issue May 17, 2019 · 0 comments · Fixed by #251
Closed

Allow timeout to be set when asyncServletModeEnabled=true #184

kclaes opened this issue May 17, 2019 · 0 comments · Fixed by #251
Milestone

Comments

@kclaes
Copy link

kclaes commented May 17, 2019

Currently (v7.4.1), the AbstractGraphQLHttpServlet allows you to use an AsyncContext to handle GraphQl queries.

There's a mechanism in place to set the timeout for subscriptions (subscriptionTimeout), but not for the actual query. This results in any query timing out after the default period of 30s (the AsyncContext default expiry).

Can a field be added to the GraphQlConfiguration that sets the timeout for the AsyncContext in AbstractGraphQLHttpServlet.doRequestAsync?

Also, if accepted, this requires the GraphQLWebAutoConfiguration to be adjusted to accomodate this extra parameter in graph-spring-boot-autoconfigure. Let me know if you'd like me to log an issue in that project as well.

@oliemansm oliemansm linked a pull request May 16, 2020 that will close this issue
@oliemansm oliemansm added this to the 9.2.0 milestone May 16, 2020
oliemansm added a commit that referenced this issue May 18, 2020
…-timeout

Allow async timeout to be configured #184
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants