Skip to content

Commit b86ac84

Browse files
committed
fixes
1 parent 2709159 commit b86ac84

File tree

2 files changed

+51
-0
lines changed

2 files changed

+51
-0
lines changed

packages/plugin/tests/__snapshots__/require-id-when-available.spec.md

Lines changed: 30 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -140,6 +140,36 @@ exports[`should report an error with union 1`] = `
140140
7 | }
141141
`;
142142

143+
exports[`should report an error with union and fragment spread 1`] = `
144+
#### ⌨️ Code
145+
146+
1 | {
147+
2 | userOrPost {
148+
3 | ... on User {
149+
4 | ...UserFields
150+
5 | }
151+
6 | }
152+
7 | }
153+
154+
#### ❌ Error
155+
156+
1 | {
157+
> 2 | userOrPost {
158+
| ^ Field \`userOrPost.id\` must be selected when it's available on a type.
159+
Include it in your selection set or add to used fragment \`UserFields\`.
160+
3 | ... on User {
161+
162+
#### 💡 Suggestion: Add \`id\` selection
163+
164+
1 | {
165+
2 | userOrPost {
166+
3 | ... on User {
167+
4 | id ...UserFields
168+
5 | }
169+
6 | }
170+
7 | }
171+
`;
172+
143173
exports[`support multiple id field names 1`] = `
144174
#### ⌨️ Code
145175

packages/plugin/tests/require-id-when-available.spec.ts

Lines changed: 21 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -379,5 +379,26 @@ ruleTester.runGraphQLTests<RuleOptions, true>('require-id-when-available', rule,
379379
documents: DOCUMENT_WITH_UNION,
380380
},
381381
},
382+
{
383+
name: 'should report an error with union and fragment spread',
384+
errors: [MESSAGE_ID],
385+
code: /* GraphQL */ `
386+
{
387+
userOrPost {
388+
... on User {
389+
...UserFields
390+
}
391+
}
392+
}
393+
`,
394+
parserOptions: {
395+
schema: USER_POST_SCHEMA,
396+
documents: /* GraphQL */ `
397+
fragment UserFields on User {
398+
name
399+
}
400+
`,
401+
},
402+
},
382403
],
383404
});

0 commit comments

Comments
 (0)