fixes issues with require-id-when-available and fragment spreads parent

Author: dotansimha

packages/plugin/src/rules/require-id-when-available.ts

@@ -82,7 +82,15 @@ const rule: GraphQLESLintRule<RequireIdWhenAvailableRuleConfig, true> = {
                 }
               }
 
-              if (!found) {
+              const { parent } = node as any;
+              const hasIdFieldInInterfaceSelectionSet =
+                parent &&
+                parent.kind === 'InlineFragment' &&
+                parent.parent &&
+                parent.parent.kind === 'SelectionSet' &&
+                !!parent.parent.selections.find(s => s.kind === 'Field' && s.name.value === fieldName);
+
+              if (!found && !hasIdFieldInInterfaceSelectionSet) {
                 context.report({
                   loc: {
                     start: {

packages/plugin/tests/require-id-when-available.spec.ts

@@ -63,13 +63,12 @@ ruleTester.runGraphQLTests('require-id-when-available', rule, {
       code: `query { hasId { name } }`,
       options: [{ fieldName: 'name' }],
     },
-  ],
-  invalid: [
     {
       ...WITH_SCHEMA,
       code: `query { vehicles { id ...on Car { mileage } } }`,
-      errors: [{ messageId: 'REQUIRE_ID_WHEN_AVAILABLE' }],
     },
+  ],
+  invalid: [
     {
       ...WITH_SCHEMA,
       code: `query { hasId { name } }`,