Skip to content

Opt-in tracing support #428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Opt-in tracing support #428

wants to merge 6 commits into from

Conversation

chris-ramon
Copy link
Member

@chris-ramon chris-ramon commented Dec 10, 2018

Overview

  • closes: Support Opentracing #426
  • This is a WIP support for Trace interface, so opentracing can be integrated.
  • This PR will only adds opt-in Tracing support, and opentracing support implementation itself will live outside graphql-go/graphql so we don't have opentracing as dependency.
  • Refer to a full working example to the new repo: opentracing-example:
    output
Test plan
  • Unit tests.

@chris-ramon chris-ramon changed the title trace support Tracing support Dec 10, 2018
@chris-ramon chris-ramon changed the title Tracing support Opt-in tracing support Dec 10, 2018
@chris-ramon chris-ramon self-assigned this Dec 10, 2018
@Fontinalis
Copy link
Collaborator

@chris-ramon When will this land in the master branch? Also, any help needed with this one? Happy to help

@coveralls
Copy link

Coverage Status

Coverage increased (+0.04%) to 91.912% when pulling acd9fcd on tracing-support into 21fe71d on master.

@chris-ramon
Copy link
Member Author

chris-ramon commented Jan 2, 2019

@chris-ramon When will this land in the master branch? Also, any help needed with this one? Happy to help

Thanks a lot for the pre-disposition to help @Fontinalis. 👍

Once this PR lands master, one great task as a help-out to this PR would be documentation on how to enable tracing, perhaps a simple example using a tracing provider from your best interest.

@linniksa
Copy link
Contributor

linniksa commented Jan 3, 2019

Can you look at https://github.com/apollographql/apollo-tracing extension , it more useful in dev environment (https://github.com/prisma/graphql-playground supports it)
maybe allow trace parse/validate stage?
is current Tracer interface allow return "path" field value as described in apollo-tracing extension (full path from root like in errors)?

@Fontinalis
Copy link
Collaborator

@chris-ramon I created a PR #448 that would add support for extensions.
@linniksa In my PR, there's an example (`star-wars-with-trace') that has a simple tracer, that basically adds the support for the "apollo-tracing". The field's resolve info can be viewed from an extension, so the full "path" field could be viewed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support Opentracing
4 participants