-
Notifications
You must be signed in to change notification settings - Fork 843
Opt-in tracing support #428
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
@chris-ramon When will this land in the master branch? Also, any help needed with this one? Happy to help |
Thanks a lot for the pre-disposition to help @Fontinalis. 👍 Once this PR lands master, one great task as a help-out to this PR would be documentation on how to enable tracing, perhaps a simple example using a tracing provider from your best interest. |
Can you look at https://github.com/apollographql/apollo-tracing extension , it more useful in dev environment (https://github.com/prisma/graphql-playground supports it) |
@chris-ramon I created a PR #448 that would add support for extensions. |
Overview
Trace
interface, soopentracing
can be integrated.opentracing
support implementation itself will live outsidegraphql-go/graphql
so we don't haveopentracing
as dependency.opentracing-example
:Test plan