Fixed deadlock when calling SendQueryAsync synchronously #332 #337
Conversation
| @@ -87,7 +87,8 @@ public async Task<GraphQLResponse<TResponse>> SendQueryAsync<TResponse>(GraphQLR | |||
| Options.EndPoint.HasWebSocketScheme()) | |||
| return await GraphQlHttpWebSocket.SendRequest<TResponse>(request, cancellationToken); | |||
|
|
|||
| return await SendHttpRequestAsync<TResponse>(request, cancellationToken); | |||
| return await SendHttpRequestAsync<TResponse>(request, cancellationToken) | |||
| .ConfigureAwait(false); | |||
There was a problem hiding this comment.
Why only there and not two lines above also ?
| @@ -143,7 +144,8 @@ private async Task<GraphQLHttpResponse<TResponse>> SendHttpRequestAsync<TRespons | |||
| var preprocessedRequest = await Options.PreprocessRequest(request, this); | |||
|
|
|||
| using var httpRequestMessage = preprocessedRequest.ToHttpRequestMessage(Options, JsonSerializer); | |||
| using var httpResponseMessage = await HttpClient.SendAsync(httpRequestMessage, HttpCompletionOption.ResponseHeadersRead, cancellationToken); | |||
| using var httpResponseMessage = await HttpClient.SendAsync(httpRequestMessage, HttpCompletionOption.ResponseHeadersRead, cancellationToken) | |||
There was a problem hiding this comment.
Why only there and not two lines below also ?
There was a problem hiding this comment.
Deadlock happens exactly because of HttpClient.SendAsync has no ConfigureAwait(false). To resolve issue #332 it's enougth to call ConfigureAwait(false) just here. But idealy whole project should be reviewed and each await should be configured. First, it will prevent from potential deadlocks, and second, it may have positive impact on performance.
There was a problem hiding this comment.
Deadlock happens exactly because of
HttpClient.SendAsynchas noConfigureAwait(false)
Could you please write a test to verify this assertion ?
There was a problem hiding this comment.
Do you meen a unit test or just simple test application to be sure?
There was a problem hiding this comment.
Unit test to be able to run on CI.
There was a problem hiding this comment.
You may call it unit or integration, whatever. The key part is to verify behavior on CI.
There was a problem hiding this comment.
I'm not sure there's somthing to test. Also I'm not sure it's posible to test ConfigureAwait or dedlock prevention. So I can't write it.
The following changes fixes deadlock problem from issue #332.
ConfigureAwait(false)onSendHttpRequestAsyncandHttpClient.SendAsync.