Refactor observable tester #213
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I see that the tests fail with the same timeout error as in my PR. |
sungam3r
reviewed
Apr 4, 2020
src/GraphQL.Client.Abstractions.Websocket/GraphQL.Client.Abstractions.Websocket.csproj
Outdated
Show resolved
Hide resolved
sungam3r
reviewed
Apr 4, 2020
tests/GraphQL.Client.Tests.Common/FluentAssertions.Reactive/FluentTestObserver.cs
Show resolved
Hide resolved
sungam3r
reviewed
Apr 4, 2020
tests/GraphQL.Client.Tests.Common/FluentAssertions.Reactive/FluentTestObserver.cs
Show resolved
Hide resolved
sungam3r
reviewed
Apr 4, 2020
tests/GraphQL.Client.Tests.Common/FluentAssertions.Reactive/ObservableAssertions.cs
Outdated
Show resolved
Hide resolved
sungam3r
reviewed
Apr 4, 2020
tests/GraphQL.Client.Tests.Common/FluentAssertions.Reactive/ObservableAssertions.cs
Outdated
Show resolved
Hide resolved
sungam3r
reviewed
Apr 4, 2020
tests/GraphQL.Client.Tests.Common/FluentAssertions.Reactive/ObservableAssertions.cs
Outdated
Show resolved
Hide resolved
sungam3r
reviewed
Apr 4, 2020
tests/GraphQL.Client.Tests.Common/FluentAssertions.Reactive/ObservableAssertions.cs
Outdated
Show resolved
Hide resolved
sungam3r
reviewed
Apr 4, 2020
tests/GraphQL.Client.Tests.Common/FluentAssertions.Reactive/ObservableExtensions.cs
Outdated
Show resolved
Hide resolved
remove excess newlines Co-Authored-By: Ivan Maximov <[email protected]>
|
Results are much better when asserting the observables asynchronously, but there is still at lease one test failing. It's not always the same test that fails! |
3 tasks
|
Finally getting consistent results on my development machine and in GitHub Actions... |
|
The I'm going to merge this (including a fix for #87) to allow this repo to progress. Still hoping for someone to come around and point me to the issue in the test... 🙄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overhaul the observable test helper classes