address review

Author: Zoran Cvetkov

graph/src/components/store/traits.rs

@@ -235,7 +235,8 @@ pub trait ReadStore: Send + Sync + 'static {
         keys: BTreeSet<EntityKey>,
     ) -> Result<BTreeMap<EntityKey, Entity>, StoreError>;
 
-    /// Looks up entities using the given store key for a range of blocks.
+    /// Returns all versions of entities of the given entity_type that were
+    /// changed in the given block_range.
     fn get_range(
         &self,
         entity_type: &EntityType,

store/postgres/src/block_range.rs

@@ -140,11 +140,11 @@ pub enum EntityBlockRange {
 }
 
 impl EntityBlockRange {
-    pub fn new(immutable: bool, block_range: std::ops::Range<BlockNumber>) -> Self {
+    pub fn new(table: &Table, block_range: std::ops::Range<BlockNumber>) -> Self {
         let start: Bound<BlockNumber> = Bound::Included(block_range.start);
         let end: Bound<BlockNumber> = Bound::Excluded(block_range.end);
         let block_range: BlockRange = BlockRange(start, end);
-        if immutable {
+        if table.immutable {
             Self::Immutable(block_range)
         } else {
             Self::Mutable(block_range)

store/postgres/src/relational.rs

@@ -530,12 +530,7 @@ impl Layout {
             for e in vec {
                 let block = e.clone().deserialize_block_number::<Entity>()?;
                 let en = e.deserialize_with_layout::<Entity>(self, None)?;
-                match entities.get_mut(&block) {
-                    Some(vec) => vec.push(en),
-                    None => {
-                        let _ = entities.insert(block, vec![en]);
-                    }
-                };
+                entities.entry(block).or_default().push(en);
             }
         }
         Ok(entities)

store/postgres/src/relational_queries.rs

@@ -2014,7 +2014,7 @@ pub struct FindRangeQuery<'a> {
 
 impl<'a> FindRangeQuery<'a> {
     pub fn new(table: &'a Table, block_range: Range<BlockNumber>) -> Self {
-        let eb_range = EntityBlockRange::new(table.immutable, block_range);
+        let eb_range = EntityBlockRange::new(&table, block_range);
         Self { table, eb_range }
     }
 }