Adapt Windows installation script to breaking change in v0.31.1 #3118
Conversation
stefanes
changed the title
There was a problem hiding this comment.
LGTM, @marctc I do not have merge permissions yet so up to you when to merge
|
Hey @stefanes, do you want fix the conflicts prior merging? thanks |
|
Not really sure how this is maintained, the installation script downloaded from https://storage.googleapis.com/cloud-onboarding/agent/scripts/grafanacloud-install.ps1 is different from the one on Not sure if this PR should go in or not, but regardless - I did update my branch with the version from
|
production/grafanacloud-install.ps1
Outdated
| Write-Host "ERROR: Required argument GCLOUD_API_KEY missing" | ||
| exit | ||
| if ($GCLOUD_HOSTED_LOGS_URL -eq "") { | ||
| Write-Host "ERROR: Required argument GCLOUD_HOSTED_LOGS_URL missing" |
There was a problem hiding this comment.
You might want to do a throw instead. Please see this comment.
There was a problem hiding this comment.
I instead changed it to verify that these parameters has been passed "the PowerShell way" (using [Parameter(Mandatory = $true)).
However, I now see this on main: 11f9010
Not sure what this new mechanism is since the instructions still mentions downloading and running this script: https://storage.googleapis.com/cloud-onboarding/agent/scripts/grafanacloud-install.ps1
There was a problem hiding this comment.
And I would argue that this script should still be updated with the changes in this PR somehow...
|
Hi @stefanes, thanks for the PR! Unfortunately, we've removed these scripts from the repo in #3485, so I have to close this PR. We wanted to take the Grafana Cloud scripts out of this repository as a part of keeping this repo be focused on Grafana Agent as an open-source, vendor-neutral project, so Grafana Cloud scripts are now managed fully by Grafana. Sorry for how this one turned out, but we do appreciate you taking the time to help keep the code base healthy! |
github-actions
bot
added
the
frozen-due-to-age
PR Description
Adapt Windows installation script to breaking change in v0.31.1
Which issue(s) this PR fixes
Notes to the Reviewer
PR Checklist