Various improvements to update.sh #45
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A more standard and widely available alternative implementation created by @dominikh in #43 (comment). Fixes #43.
Using mktemp solves two issues: - it allows running multiple instances of update.sh in parallel. For example, someone might have two separate checkouts of the playground and intent to build them with different versions of Go. They might run both instances of update.sh in parallel to save time. - it works correctly when someone has set their TMPDIR to something other than /tmp
Even quote the use of PKG. While not necessary right now, it protects us from future code breakage.
|
PTAL |
|
Awesome. I've reviewed all commits, and the final version. It's a huge improvement, and continues to work on OS X. LGTM. Thank you for making it better! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #44