Skip to content

Update GopherJS Playground to Go 1.6. #42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 21, 2016
Merged

Update GopherJS Playground to Go 1.6. #42

merged 1 commit into from
Feb 21, 2016

Conversation

dmitshur
Copy link
Member

This is based on work in #41, which allows this entire step to be done
in a matter of seconds by simply running one command:

go generate github.com/gopherjs/gopherjs.github.io/playground

And it works even with multiple GOPATHs, and non-writeable GOROOT. \o/

It literally took me seconds to create this PR! Instead of what it used to take in the past (anywhere between 20-60 minutes depending on how recently I had done this manual operation).

(Note, this PR was generated with the work done in #41.)

image

This is based on work in #41, which allows this entire step to be done
in a matter of seconds by simply running one command:

	go generate github.com/gopherjs/gopherjs.github.io/playground

And it works even with multiple GOPATHs, and non-writeable GOROOT. \o/
@dmitshur
Copy link
Member Author

Reviewed this myself, LGTM based on the fact that last such PR was reviewed with a comment "nothing to review, merge if it works" (see #39 (comment)). /cc @dominikh

Test plan, I used goexec 'http.ListenAndServe(":8080", http.FileServer(http.Dir(".")))' to start an HTTP server serving contents of playground directory, then visited localhost:8080 in browser, hard-cleared all cache, and tested a small Go program. It worked without errors:

image

@dmitshur dmitshur merged commit 219c7c2 into master Feb 21, 2016
@dmitshur dmitshur deleted the playground-go1.6 branch February 21, 2016 05:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant