-
Notifications
You must be signed in to change notification settings - Fork 5
Implement set #29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement set #29
Conversation
Signed-off-by: zegabr <[email protected]>
Signed-off-by: zegabr <[email protected]>
I've implemented most of the methods I found on the List implementation. But as this is a Set implementation, what do you think of implementing some Set operations like: Union(s1, s2) -> returns a new set as the union of both sets |
Another thing: Considering this thread, as far as I understood, the Let me know if you agree with that. |
That's a great idea. But, let's not bring it into this issue. We can create a separate issue for that. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM ! @zegabr Thanks for your contribution.
We can merge it once other codeowners approve it.
Got it. Feel free to also assign it to me :) |
Description
Add Set implementation
Related Issues
Closes #24
Checklist