Skip to content

Change EditorMeasurement to use secure connection (Fixed #484) #548

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 6, 2022
Merged

Change EditorMeasurement to use secure connection (Fixed #484) #548

merged 1 commit into from
Oct 6, 2022

Conversation

chkuang-g
Copy link
Collaborator

@chkuang-g chkuang-g commented Oct 4, 2022 •
edited
Loading

#484

EditorMeasurement used to use http:// instead of https:// to report editor usage. This is causing later version of Unity to log warnings and errors. Even though this is harmless, the logs still looks concerning.

This change basically change http to https.

Testing

  • Local integration test with Unity 2018-2021.
  • Manual test using Firebase Analytics with Unity 2022-2023 because EDM4U current cannot be built by the build tools from Unity 2022-2023.

@chkuang-g chkuang-g changed the title Change EditorMeasurement to use secure connection (Fix #484) Change EditorMeasurement to use secure connection (Fixed #484) Oct 4, 2022
@chkuang-g chkuang-g merged commit a08c051 into master Oct 6, 2022
@chkuang-g chkuang-g deleted the patch/non-secure branch October 6, 2022 17:10
chkuang-g added a commit that referenced this pull request Oct 7, 2022
@chkuang-g
Change EditorMeasurement to use secure connection (#548)
50c1e44
@googlesamples googlesamples locked and limited conversation to collaborators Nov 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@DellaBitta DellaBitta DellaBitta approved these changes

@a-maurice a-maurice Awaiting requested review from a-maurice

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chkuang-g @DellaBitta