Skip to content

Workaroud when AssetDatabase.CreateFolder failed #543

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 30, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 25 additions & 1 deletion source/VersionHandlerImpl/src/FileUtils.cs
Original file line number Diff line number Diff line change
Expand Up @@ -618,6 +618,22 @@ public static RemoveAssetsResult RemoveAssets(IEnumerable<string> filenames,
return result;
}

/// <summary>
/// Check if a guid returned from Unity API is valid.
/// </summary>
/// <param name="guid">GUID returned from Unity API.</param>
/// <returns>True if the guid is valid.</returns>
internal static bool IsValidGuid(string guidStr) {
if(String.IsNullOrEmpty(guidStr)) return false;
try {
var guid = new Guid(guidStr);
if (guid == Guid.Empty) return false;
} catch (FormatException e) {
return false;
}
return true;
}

/// <summary>
/// Recursively create all parent folders given a path.
/// </summary>
Expand All @@ -632,7 +648,15 @@ public static bool CreateFolder(string path) {
if (!CreateFolder(parentFolder)) {
return false;
}
return !String.IsNullOrEmpty(AssetDatabase.CreateFolder(parentFolder, di.Name));

// Try to use Unity API to create folder. However, some versions of Unity has issue to
// create folders with version number in it like '9.0.0'. In this case, instead of
// returnig empty guid, it can return guids with all zeroes.
if (IsValidGuid(AssetDatabase.CreateFolder(parentFolder, di.Name))) {
return true;
}

return Directory.CreateDirectory(path) != null;
}

/// <summary>
Expand Down
45 changes: 45 additions & 0 deletions source/VersionHandlerImpl/unit_tests/src/FileUtilsTest.cs
Original file line number Diff line number Diff line change
Expand Up @@ -391,5 +391,50 @@ public void ReplaceBaseAssetsOrPackagesFolder() {
"Foo/Bar", "Assets"),
Is.EqualTo("Foo/Bar"));
}

/// <summary>
/// Test FileUtils.IsValidGuid() when it returns true
/// </summary>
[Test]
public void IsValidGuid_TrueCases() {
Assert.That(
FileUtils.IsValidGuid("4b7c4a82-79ca-4eb5-a154-5d78a3b3d3d7"),
Is.EqualTo(true));

Assert.That(
FileUtils.IsValidGuid("017885d9f22374a53844077ede0ccda6"),
Is.EqualTo(true));
}

/// <summary>
/// Test FileUtils.IsValidGuid() when it returns false
/// </summary>
[Test]
public void IsValidGuid_FalseCases() {
Assert.That(
FileUtils.IsValidGuid(""),
Is.EqualTo(false));
Assert.That(
FileUtils.IsValidGuid(null),
Is.EqualTo(false));
Assert.That(
FileUtils.IsValidGuid("00000000-0000-0000-0000-000000000000"),
Is.EqualTo(false));
Assert.That(
FileUtils.IsValidGuid("00000000000000000000000000000000"),
Is.EqualTo(false));
Assert.That(
FileUtils.IsValidGuid("g000000000000000000000000000000"),
Is.EqualTo(false));
Assert.That(
FileUtils.IsValidGuid(" "),
Is.EqualTo(false));
Assert.That(
FileUtils.IsValidGuid("12300000 0000 0000 0000 000000000000"),
Is.EqualTo(false));
Assert.That(
FileUtils.IsValidGuid("12300000\n0000\n0000\n0000\n000000000000"),
Is.EqualTo(false));
}
}
}