[Bug] Confusing version comparison: version2 = version1.EndsWith("+")

[qbit86]

[REQUIRED] Please fill in the following fields:

• Unity editor version: 2018.4.10f1
• External Dependency Manager version: 1.2.165
• Source you installed EDM4U: .unitypackage
• Features in External Dependency Manager in use: Android Resolver, VersionHandler
• Plugins SDK in use: Firebase, Facebook, etc.
• Platform you are using the Unity editor on: Mac, Windows

[REQUIRED] Please describe the issue here:

I was reading sources of Dependency class investigating another issue. And was confused by this argument coercion in IsGreater() method [1]:

version2 = version1.EndsWith("+") ?
    version2.Substring(0, version2.Length - 1) : version2;

Shouldn't it be version2?

version2 = version2.EndsWith("+") ? ...

Or with TrimEnd() [2]:

version2 = version2?.TrimEnd(...);

Please answer the following, if applicable:

What's the issue repro rate?

100%

How can we make the problem occur?

Take a look at Dependency.IsGreater(string version1, string version2)

[1] source/JarResolverLib/src/Google.JarResolver/Dependency.cs#L196
[2] https://docs.microsoft.com/en-us/dotnet/api/system.string.trimend?view=net-5.0

[google-oss-bot]

This issue does not seem to follow the issue template. Make sure you provide all the required information.

[chkuang-g]

Thanks for catching this!

This should be fixed in #443 and will be included in the next release.

If you need the patch immediately, you can build EDM4U from source using:

# Build .unitypackage to build/ folder
./gradlew buildPlugin

# Build .tgz to build/ folder
./gradlew buildUpmPlugin

[DellaBitta]

I'm going to close this issue for now. If the upcoming change does not fix your issue in the next release, then please re-open this ticket to let us know! Thanks!