Skip to content

feat: add new Places fields to Place Details #889

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
wangela merged 8 commits into from
Mar 29, 2023
Merged

feat: add new Places fields to Place Details #889

wangela merged 8 commits into from
Mar 29, 2023

Conversation

@wangela
Copy link
Member

@wangela wangela commented Jan 30, 2023 •
edited
Loading

New Place Details fields and request parameters were announced in this blog post for the Places API.

Added:

  • reviews_no_translation
  • reviews_sort
  • fields
    • curbside_pickup
    • current_opening_hours
    • delivery
    • dine_in
    • editorial_summary
    • reservable
    • reviews (deprecates review field in favor of documented plural)
    • secondary_opening_hours
    • serves_beer
    • serves_breakfast
    • serves_brunch
    • serves_dinner
    • serves_lunch
    • serves_vegetarian_food
    • serves_wine
    • takeout
    • wheelchair_accessible_entrance

Fixes #901

@wangela wangela requested a review from amuramoto January 30, 2023 23:24
@wangela wangela assigned wangela and unassigned arriolac Jan 30, 2023
@wangela wangela merged commit 62a8b50 into main Mar 29, 2023
@wangela wangela deleted the wangela/places-fields branch March 29, 2023 23:17
googlemaps-bot pushed a commit that referenced this pull request Mar 30, 2023
@semantic-release-bot
chore(release): 2.2.0 [skip ci]
1b07d44 
# [2.2.0](v2.1.2...v2.2.0) (2023-03-30)

### Bug Fixes

* javadoc in PlaceDetailsRequest ([#903](#903)) ([b5b5c6c](b5b5c6c))

### Features

* add new Places fields to Place Details ([#889](#889)) ([62a8b50](62a8b50))
@googlemaps-bot
Copy link
Contributor

googlemaps-bot commented Mar 30, 2023

🎉 This PR is included in version 2.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@ZeroOne3010
Copy link

ZeroOne3010 commented Nov 7, 2023

To whom it may concern: version 2.2.0 failed to adhere to the Semantic Versioning system, as this PR removed a part of the public API in a backward incompatible change. The public Boolean permanentlyClosed; field was removed from the OpeningHours class (without even being deprecated first). With a change like this, the major version must be incremented.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@amuramoto amuramoto amuramoto approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@wangela wangela

Labels

released

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Places: PlaceOpeningHours does not include special days

5 participants

@wangela @googlemaps-bot @ZeroOne3010 @amuramoto @arriolac