feat: Add "transfer_manager" module for concurrent uploads and downloads, as a preview feature #943
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* add samples, tests pending * add snippet tests * snippet and snippets_test.py linting * snippets; recursive directory creation; rename some params * Add directory upload snippet
product-auto-label
bot
added
size: xl
andrewsg
changed the title
frankyn
approved these changes
Dec 6, 2022
Contributor
frankyn
left a comment
frankyn
left a comment
There was a problem hiding this comment.
Just a nit; thanks for addressing the comments from yesterday's discussion.
| # limitations under the License. | ||
|
|
||
|
|
||
| def upload_many_blobs_with_transfer_manager( |
Contributor
There was a problem hiding this comment.
After this PR / release can you split these samples into respective files?
| from google.api_core import exceptions | ||
|
|
||
|
|
||
| def test_upload_many(shared_bucket, file_data, blobs_to_delete): |
Contributor
There was a problem hiding this comment.
In a subsequent PR please add a file object of 16mib range so it tests resumable upload code path
This was referenced Jan 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a "transfer_manager" module which enables concurrent downloads and uploads of multiple files via the use of a thread pool. Transfer Manager is a preview feature and the API and behavior are subject to change before a GA launch of the feature in the future. A warning is emitted on import to this effect. Please do not hesitate to submit bugs and general feedback, positive or negative, by opening a github issue.
The performance of this feature is sensitive to the value of the "threads" parameter and the specifics of the environment and workload. Read the docstrings on "threads" and experiment to find what works best for each use case.