Skip to content

Commit e4990d0

Browse files
author
Gurov Ilya
authored
feat(storage): migrate to Service Account Credentials API (#189)
1 parent 4d76e38 commit e4990d0

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

google/cloud/storage/_signing.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -660,14 +660,14 @@ def _sign_message(message, access_token, service_account_email):
660660
message = _helpers._to_bytes(message)
661661

662662
method = "POST"
663-
url = "https://iam.googleapis.com/v1/projects/-/serviceAccounts/{}:signBlob?alt=json".format(
663+
url = "https://iamcredentials.googleapis.com/v1/projects/-/serviceAccounts/{}:signBlob?alt=json".format(
664664
service_account_email
665665
)
666666
headers = {
667667
"Authorization": "Bearer " + access_token,
668668
"Content-type": "application/json",
669669
}
670-
body = json.dumps({"bytesToSign": base64.b64encode(message).decode("utf-8")})
670+
body = json.dumps({"payload": base64.b64encode(message).decode("utf-8")})
671671

672672
request = requests.Request()
673673
response = request(url=url, method=method, body=body, headers=headers)
@@ -678,7 +678,7 @@ def _sign_message(message, access_token, service_account_email):
678678
)
679679

680680
data = json.loads(response.data.decode("utf-8"))
681-
return data["signature"]
681+
return data["signedBlob"]
682682

683683

684684
def _url_encode(query_params):

tests/unit/test__signing.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -678,7 +678,7 @@ def _call_fut(*args, **kwargs):
678678

679679
def test_sign_bytes(self):
680680
signature = "DEADBEEF"
681-
data = {"signature": signature}
681+
data = {"signedBlob": signature}
682682
request = make_request(200, data)
683683
with mock.patch("google.auth.transport.requests.Request", return_value=request):
684684
returned_signature = self._call_fut(

0 commit comments

Comments
 (0)