chore: fix lint and flake8 sessions (#1103)

cojenco · web-flow · commit d9b2065f5368 · 2023-08-09T10:06:45.000-07:00
diff --git a/google/cloud/storage/acl.py b/google/cloud/storage/acl.py
@@ -137,7 +137,6 @@ class ACL(object):
 
     # Subclasses must override to provide these attributes (typically,
     # as properties).
-    client = None
     reload_path = None
     save_path = None
     user_project = None
diff --git a/google/cloud/storage/client.py b/google/cloud/storage/client.py
@@ -147,7 +147,7 @@ def __init__(
         kw_args["api_endpoint"] = storage_host if _is_emulator_set else None
 
         if client_options:
-            if type(client_options) == dict:
+            if isinstance(client_options, dict):
                 client_options = google.api_core.client_options.from_dict(
                     client_options
                 )
diff --git a/tests/unit/test_transfer_manager.py b/tests/unit/test_transfer_manager.py
@@ -192,7 +192,7 @@ def test_upload_many_suppresses_412_with_skip_if_exists():
         worker_type=transfer_manager.THREAD,
     )
     for result in results:
-        assert type(result) == exceptions.PreconditionFailed
+        assert isinstance(result, exceptions.PreconditionFailed)
 
 
 def test_upload_many_with_processes():

Original file line number	Diff line number	Diff line change
`@@ -147,7 +147,7 @@ def __init__(`
`147`	`147`	`kw_args["api_endpoint"] = storage_host if _is_emulator_set else None`
`148`	`148`
`149`	`149`	`if client_options:`
`150`		`- if type(client_options) == dict:`
	`150`	`+ if isinstance(client_options, dict):`
`151`	`151`	`client_options = google.api_core.client_options.from_dict(`
`152`	`152`	`client_options`
`153`	`153`	`)`
Original file line number	Diff line number	Diff line change
`@@ -192,7 +192,7 @@ def test_upload_many_suppresses_412_with_skip_if_exists():`
`192`	`192`	`worker_type=transfer_manager.THREAD,`
`193`	`193`	`)`
`194`	`194`	`for result in results:`
`195`		`- assert type(result) == exceptions.PreconditionFailed`
	`195`	`+ assert isinstance(result, exceptions.PreconditionFailed)`
`196`	`196`
`197`	`197`
`198`	`198`	`def test_upload_many_with_processes():`