chore: enable mypy testing #1057
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
size: m
|
Looks like one more type validation needs to be fixed: https://github.com/googleapis/python-firestore/actions/runs/15219606300/job/42812618562?pr=1057 |
cindy-peng
previously approved these changes
May 23, 2025
Thanks, it looks like upstream brought in a new type to fix! Should be fixed now |
cindy-peng
approved these changes
May 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables mypy type checking, so we can validate consistent types across the library. It also includes small changes to get type validation to pass
Over time, we can add typing to more areas, and make sure any changes pass the mypy check
Fixes: #900