Skip to content

Conversation

plamut
Copy link
Contributor

@plamut plamut commented Jan 22, 2021

Fixes #473.

This PR fixes the ignored project parameter for load jobs (the client's default project was incorrectly always used).

PR checklist:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

@plamut plamut requested review from a team and tswast and removed request for a team January 22, 2021 16:50
@product-auto-label product-auto-label bot added the api: bigquery Issues related to the googleapis/python-bigquery API. label Jan 22, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Jan 22, 2021
@plamut plamut changed the title fix: fix: use explicitly given project over the client's default project for load jobs Jan 22, 2021
Copy link
Contributor

@tswast tswast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks!

@tswast tswast merged commit 530e1e8 into googleapis:master Jan 22, 2021
@plamut plamut deleted the iss-473 branch January 24, 2021 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: bigquery Issues related to the googleapis/python-bigquery API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Creating a load job in a project other than the client's project results in error

2 participants