Skip to content

feat: add support for unrecognized model types #401

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 30, 2020
Merged

feat: add support for unrecognized model types #401

merged 3 commits into from
Nov 30, 2020

Conversation

steffnay
Copy link
Contributor

@steffnay steffnay commented Nov 25, 2020 •
edited
Loading

If fails to parse model type enum, sets to MODEL_TYPE_UNSPECIFIED.

  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #334 🦕

@steffnay steffnay requested review from a team and pmakani November 25, 2020 13:15
@product-auto-label product-auto-label bot added the api: bigquery Issues related to the googleapis/python-bigquery API. label Nov 25, 2020
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Nov 25, 2020
@steffnay steffnay requested a review from tswast November 25, 2020 14:23
tswast
tswast approved these changes Nov 30, 2020
View reviewed changes
Copy link
Contributor

@tswast tswast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wonderful!

@steffnay steffnay merged commit 168f035 into googleapis:master Nov 30, 2020
@release-please release-please bot mentioned this pull request Jan 4, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tswast tswast tswast approved these changes

@pmakani pmakani Awaiting requested review from pmakani

Assignees
No one assigned
Labels
api: bigquery Issues related to the googleapis/python-bigquery API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make Model constructor robust against new model types
2 participants
@steffnay @tswast