Skip to content

Conversation

tswast
Copy link
Collaborator

@tswast tswast commented Dec 10, 2024

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #824 🦕

@tswast tswast requested review from a team as code owners December 10, 2024 19:47
@tswast tswast requested a review from farhan0102 December 10, 2024 19:47
@product-auto-label product-auto-label bot added the size: s Pull request size is small. label Dec 10, 2024
@product-auto-label product-auto-label bot added the api: bigquery Issues related to the googleapis/python-bigquery-pandas API. label Dec 10, 2024
@tswast tswast requested review from Linchin, chalmerlowe and leahecole and removed request for farhan0102 December 10, 2024 19:50
Copy link
Contributor

@Linchin Linchin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you!

@Linchin Linchin assigned Linchin and unassigned whuffman36 Dec 12, 2024
@Linchin Linchin enabled auto-merge (squash) December 12, 2024 21:32
@Linchin Linchin merged commit 5004d08 into main Dec 12, 2024
22 of 25 checks passed
@Linchin Linchin deleted the issue824-bigframes branch December 12, 2024 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: bigquery Issues related to the googleapis/python-bigquery-pandas API. size: s Pull request size is small.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feature request: to_gbq with a bigframes.pandas.DataFrame should call .to_gbq() from BigQuery DataFrames not download and re-upload

3 participants