fix: avoid TypeError when executing DML statements with read_gbq
#483
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
the
api: bigquery
steffnay
approved these changes
Feb 22, 2022
shollyman
reviewed
Feb 24, 2022
| @@ -495,6 +496,11 @@ def run_query(self, query, max_results=None, progress_bar_type=None, **kwargs): | |||
| except self.http_error as ex: | |||
| self.process_http_error(ex) | |||
|
|
|||
| # Avoid attempting to download results from DML queries, which have no | |||
| # destination. | |||
There was a problem hiding this comment.
This will also impact scripts as well; do you need additional handling for that case (example: the last line in a script is a SELECT)
There was a problem hiding this comment.
That's on the TODO list: #149 (comment)
The to_dataframe method in google-cloud-bigquery can call getQueryResults now, which should handle the scripting case. Though I'm actually not sure what happens when we try to use the BQ Storage API in google-cloud-bigquery with a script. Filed googleapis/python-bigquery#1148 to investigate this in google-cloud-bigquery.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #481 🦕