Skip to content

test: exclude gcsfs 2024.3.1 to unblock PRs #466

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Conversation

shobsi
Copy link
Contributor

@shobsi shobsi commented Mar 19, 2024

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes internal issue 330235782 🦕

@shobsi shobsi requested review from a team as code owners March 19, 2024 02:32
@shobsi shobsi requested a review from TrevorBergeron March 19, 2024 02:32
@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. labels Mar 19, 2024
@chelsea-lin chelsea-lin added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Mar 19, 2024
@product-auto-label product-auto-label bot added size: s Pull request size is small. and removed size: xs Pull request size is extra small. labels Mar 19, 2024
# to install necessary dependencies with appropriate versions.
# TODO(shobs): Remove the exclusion after the issue is fixed:
# https://github.com/fsspec/gcsfs/issues/616
session.install("aiohttp!=4.0.0a0, !=4.0.0a1")
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't want to go down the route of figuring out further dependencies and install them each with --no-deps. Is this acceptable @tswast ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO, I don't think we should ask users to exclude this version of gcsfs. Here are the reasons:

  • The issue is under discussions between "by design" or "updating default values".
  • The issue does not affect BigFrames product codes, while the affected tests are able to find a work around solution (PR)

@shobsi
Copy link
Contributor Author

shobsi commented Mar 22, 2024

Since bigframes.pandas.read_* has dependency on pandas.read_*, the break of the latter in gcsfs 2024.3.1 for wildcard gcs paths is theoretically a break of the former as well. But I tested offline that bigframes.pandas.read_* was never working with wildcard paths for other reasons. So we don't need to worry about the backward compatibility of bigframes itself with gcsfs version 2024.3.1. @chelsea-lin has already worked around the test failures by adjusting the wildcard paths in pandas.read_*.

@shobsi shobsi closed this Mar 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. do not merge Indicates a pull request not ready for merge, due to either quality or timing. size: s Pull request size is small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants