Skip to content

fix: raise ValueError when read_pandas() receives a bigframes DataFrame #447

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 15, 2024
Merged

fix: raise ValueError when read_pandas() receives a bigframes DataFrame #447

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0fb1a04
fix: raise `ValueError` when `read_pandas()` receives a bigframes `Da…
tswast Mar 15, 2024
99b7556
make actually a unit test
tswast Mar 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions bigframes/session/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -916,6 +916,12 @@ def read_pandas(self, pandas_dataframe: pandas.DataFrame) -> dataframe.DataFrame
def _read_pandas(
self, pandas_dataframe: pandas.DataFrame, api_name: str
) -> dataframe.DataFrame:
if isinstance(pandas_dataframe, dataframe.DataFrame):
raise ValueError(
"read_pandas() expects a pandas.DataFrame, but got a "
"bigframes.pandas.DataFrame."
)

if (
pandas_dataframe.size < MAX_INLINE_DF_SIZE
# TODO(swast): Workaround data types limitation in inline data.
Expand Down
15 changes: 15 additions & 0 deletions tests/unit/session/test_io_pandas.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,9 @@
# limitations under the License.

import datetime
import re
from typing import Dict, Union
import unittest.mock as mock

import geopandas # type: ignore
import numpy
Expand All @@ -24,8 +26,11 @@
import pytest

import bigframes.features
import bigframes.pandas
import bigframes.session._io.pandas

from .. import resources

_LIST_OF_SCALARS = [
[1, 2, 3],
[],
Expand Down Expand Up @@ -475,3 +480,13 @@ def test_arrow_to_pandas_wrong_size_dtypes(
):
with pytest.raises(ValueError, match=f"Number of types {len(dtypes)}"):
bigframes.session._io.pandas.arrow_to_pandas(arrow_table, dtypes)


def test_read_pandas_with_bigframes_dataframe():
session = resources.create_bigquery_session()
df = mock.create_autospec(bigframes.pandas.DataFrame, instance=True)

with pytest.raises(
ValueError, match=re.escape("read_pandas() expects a pandas.DataFrame")
):
session.read_pandas(df)