Skip to content

chore: don't require branch to be synced with main to merge #425

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 11, 2024

Conversation

tswast
Copy link
Collaborator

@tswast tswast commented Mar 8, 2024

Many recent changes (e.g. docs) don't need to be synced with main to be pretty confident they are safe to merge.

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

Many recent changes (e.g. docs) don't need to be synced with `main` to be pretty confident they are safe to merge.
@tswast tswast requested review from a team as code owners March 8, 2024 23:03
@tswast tswast requested a review from TrevorBergeron March 8, 2024 23:03
@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. labels Mar 8, 2024
Copy link
Contributor

@parthea parthea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tswast tswast added the automerge Merge the pull request once unit tests and other checks pass. label Mar 11, 2024
@gcf-merge-on-green gcf-merge-on-green bot merged commit 60594f4 into main Mar 11, 2024
@gcf-merge-on-green gcf-merge-on-green bot deleted the tswast-patch-1 branch March 11, 2024 14:52
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: xs Pull request size is extra small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants