-
Notifications
You must be signed in to change notification settings - Fork 51
feat: Support audio_transcribe with partial ordering #1908
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
shuoweil
wants to merge
10
commits into
main
Choose a base branch
from
shuowei-transcribe-partial-order
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+139
−3
Draft
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
159ddc0
handle corner case of null ptr
shuoweil d264db0
add testcase
shuoweil cddd769
snapshot update
shuoweil 8a36137
revert change to tests/unit/core/compile/sqlglot/expressions/snapshot…
shuoweil 7d799f6
Restore out.sql to match main branch
shuoweil 5492808
Revert "Restore out.sql to match main branch"
shuoweil 1811b47
Revert "revert change to tests/unit/core/compile/sqlglot/expressions/…
shuoweil 1e439af
Revert "snapshot update"
shuoweil 37a55b0
check if both perands hav null indices before applying the block iden…
shuoweil 5560902
change the line sepearation
shuoweil File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -454,3 +454,26 @@ def test_blob_transcribe( | |
assert ( | ||
keyword.lower() in actual_text.lower() | ||
), f"Item (verbose={verbose}): Expected keyword '{keyword}' not found in transcribed text. " | ||
|
||
|
||
@pytest.mark.parametrize( | ||
"model_name", | ||
[ | ||
"gemini-2.0-flash-001", | ||
"gemini-2.0-flash-lite-001", | ||
], | ||
) | ||
def test_audio_transcribe_partial_ordering_integration( | ||
audio_mm_df_partial_ordering: bpd.DataFrame, | ||
model_name: str, | ||
): | ||
"""Integration test for audio_transcribe with partial ordering mode.""" | ||
df = audio_mm_df_partial_ordering.copy() | ||
bpd.options.bigquery.ordering_mode = "partial" | ||
|
||
df["transcribed_text"] = df["audio"].blob.audio_transcribe(model_name=model_name) | ||
result = df.to_pandas(ordered=False) | ||
|
||
assert "transcribed_text" in result.columns | ||
assert len(result) > 0 | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The number of rows in |
||
assert result["transcribed_text"].iloc[0] is not None |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This doesn't seem desirable. If df1 is n rows and df2 is m rows, won't this end up with n x m rows?