refactor: Simplify local arrow data management #1591
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
size: m
TrevorBergeron
force-pushed
the
local_storage_df
branch
2 times, most recently
from
b8b6438 to
8d504a5
Compare
TrevorBergeron
force-pushed
the
local_storage_df
branch
from
8d504a5 to
aade6cb
Compare
TrevorBergeron
requested review from
tswast and
sycai
and removed request for
ZehaoXU
sycai
approved these changes
Apr 4, 2025
bigframes/core/local_data.py
Outdated
| total_bytes: int | ||
| row_count: int | ||
|
|
||
| @staticmethod |
There was a problem hiding this comment.
nit: It feels like @classmethod is a better fit for factory methods like this
There was a problem hiding this comment.
yeah, thats true, changed in new revision
| # allows directly using values out of a duration arrow array | ||
| if isinstance(value, datetime.timedelta): | ||
| value = ( | ||
| (value.days * 3600 * 24) + value.seconds |
There was a problem hiding this comment.
Could we use value.total_seconds() ? It might simplify the expression a bit
There was a problem hiding this comment.
eh, floats are evil though, also I copied from https://github.com/googleapis/python-bigquery-dataframes/blame/2ce891fcd5bfd9f093fbcbb1ea35158d2bf9d8b9/bigframes/core/utils.py#L219-L222
TrevorBergeron
force-pushed
the
local_storage_df
branch
from
82b6816 to
8dcc03d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> 🦕