Skip to content

chore: Remove most unit tests, lint, doc testing from kokoro presubmit #1459

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Mar 12, 2025
Merged

chore: Remove most unit tests, lint, doc testing from kokoro presubmit #1459

merged 8 commits into from
Mar 12, 2025

Conversation

TrevorBergeron
Copy link
Contributor

@TrevorBergeron TrevorBergeron commented Mar 5, 2025 •
edited
Loading

b/Fixes: b/401037761

@TrevorBergeron TrevorBergeron requested review from a team as code owners March 5, 2025 23:08
@TrevorBergeron TrevorBergeron requested a review from shuoweil March 5, 2025 23:08
@product-auto-label product-auto-label bot added the size: xs Pull request size is extra small. label Mar 5, 2025
@product-auto-label product-auto-label bot added the api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. label Mar 5, 2025
@product-auto-label product-auto-label bot added size: s Pull request size is small. and removed size: xs Pull request size is extra small. labels Mar 5, 2025
@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. and removed size: s Pull request size is small. labels Mar 5, 2025
@TrevorBergeron TrevorBergeron changed the title chore: Remote most unit tests, lint, doc testing from kokoro presubmit chore: Remove most unit tests, lint, doc testing from kokoro presubmit Mar 5, 2025
@TrevorBergeron TrevorBergeron added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Mar 5, 2025
@product-auto-label product-auto-label bot added size: s Pull request size is small. and removed size: xs Pull request size is extra small. labels Mar 5, 2025
@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. and removed size: s Pull request size is small. labels Mar 5, 2025
@product-auto-label product-auto-label bot added size: s Pull request size is small. and removed size: xs Pull request size is extra small. labels Mar 6, 2025
@TrevorBergeron TrevorBergeron mentioned this pull request Mar 6, 2025
Merged
tswast
tswast reviewed Mar 6, 2025
View reviewed changes
bigframes/blob/_functions.py Outdated
@@ -393,7 +393,7 @@ def pdf_extract_func(src_obj_ref_rt: str) -> str:
return all_text


pdf_extract_def = FunctionDef(pdf_extract_func, ["pypdf", "requests"])
pdf_extract_def = FunctionDef(pdf_extract_func, ["pypdf", "requests", "pypdf[crypto]"])
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was this a merge conflict error?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, merge issue, re-updated branch, shouldn't show up anymore now

tswast
tswast reviewed Mar 6, 2025
View reviewed changes
noxfile.py
"mypy",
"format",
"docs",
"docfx",
"unit",
Copy link
Collaborator

@tswast tswast Mar 6, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why keep unit but remove unit_noextras?

Edit: Oh, is it for the test coverage? Ideally we make some separate coverage targets for system vs unit tests at some point.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, its for coverage, didn't want to mess too much with that, I doubt either unit, or integration tests individually would meet the coverage requirement. Maybe could just run unit tests as part of the integration suite though?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the PR#1460 we are adding back format and mypy, but what about the others?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

others are already covered by existing docs, unit test actions, so are already redundant

@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. and removed size: s Pull request size is small. labels Mar 6, 2025
@TrevorBergeron TrevorBergeron requested review from tswast and shobsi March 12, 2025 17:14
@TrevorBergeron TrevorBergeron removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Mar 12, 2025
@TrevorBergeron TrevorBergeron merged commit 742494c into main Mar 12, 2025
24 checks passed
@TrevorBergeron TrevorBergeron deleted the fast_presubmits branch March 12, 2025 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tswast tswast tswast approved these changes

@shuoweil shuoweil Awaiting requested review from shuoweil shuoweil is a code owner automatically assigned from googleapis/api-bigquery-dataframe

@shobsi shobsi Awaiting requested review from shobsi

Assignees

@tswast tswast

Labels
api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: xs Pull request size is extra small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@TrevorBergeron @tswast @shobsi @shuoweil