Skip to content

feat: Add +, - as unary ops, ^ binary op #724

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
May 29, 2024
Merged

feat: Add +, - as unary ops, ^ binary op #724

merged 5 commits into from
May 29, 2024

Conversation

TrevorBergeron
Copy link
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

@TrevorBergeron TrevorBergeron requested review from a team as code owners May 24, 2024 22:48
@product-auto-label product-auto-label bot added the size: m Pull request size is medium. label May 24, 2024
@product-auto-label product-auto-label bot added the api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. label May 24, 2024
ashleyxuu
ashleyxuu approved these changes May 29, 2024
View reviewed changes
third_party/bigframes_vendored/pandas/core/frame.py Outdated
Object to bitwise AND with the DataFrame.

Returns:
DataFrame: The result of the operation.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Return type should be bigframes.dataframe.DataFrame so that the docs can be linked automatically. eg: https://screenshot.googleplex.com/4FqTHqfjTpzNbim

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done, though will need a full pass later if we want this on all docstrings

third_party/bigframes_vendored/pandas/core/series.py Outdated
Object to bitwise XOR with the Series.

Returns:
Series: The result of the operation.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: same here: https://screenshot.googleplex.com/6vuZvEQfhdWKVad

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@TrevorBergeron TrevorBergeron enabled auto-merge (squash) May 29, 2024 22:18
@TrevorBergeron TrevorBergeron merged commit 968d825 into main May 29, 2024
@TrevorBergeron TrevorBergeron deleted the dunders branch May 29, 2024 23:15
@release-please release-please bot mentioned this pull request May 29, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@milkshakeiii milkshakeiii Awaiting requested review from milkshakeiii milkshakeiii is a code owner automatically assigned from googleapis/api-bigquery-dataframe

1 more reviewer

@ashleyxuu ashleyxuu ashleyxuu approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@ashleyxuu ashleyxuu

Labels
api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: m Pull request size is medium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TrevorBergeron @ashleyxuu