Skip to content

docs: integrations notebook extracts token from bqclient._http.credentials instead of bqclient._credentials #1784

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 30, 2025

Conversation

tswast
Copy link
Collaborator

@tswast tswast commented May 30, 2025

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Follow-up to #1755 and b/419106112 🦕

@tswast tswast requested review from a team as code owners May 30, 2025 21:08
@tswast tswast requested a review from chelsea-lin May 30, 2025 21:08
@product-auto-label product-auto-label bot added the size: m Pull request size is medium. label May 30, 2025
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@product-auto-label product-auto-label bot added the api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. label May 30, 2025
@@ -66,9 +66,21 @@
"name": "stderr",
Copy link
Collaborator Author

@tswast tswast May 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line #8.        token = bqclient._http.credentials.token

FYI: This is the only code line that changes.


Reply via ReviewNB

@tswast tswast merged commit 6e63eca into main May 30, 2025
16 of 24 checks passed
@tswast tswast deleted the b419106112-connection-pool-integrations-notebook branch May 30, 2025 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: m Pull request size is medium.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants