Skip to content

Conversation

chelsea-lin
Copy link
Contributor

No description provided.

@chelsea-lin chelsea-lin requested review from tswast and sycai April 22, 2025 23:45
@chelsea-lin chelsea-lin requested review from a team as code owners April 22, 2025 23:45
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@product-auto-label product-auto-label bot added size: xl Pull request size is extra large. api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. labels Apr 22, 2025
@@ -0,0 +1,483 @@
{
Copy link
Contributor

@sycai sycai Apr 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The DataFrame.struct does not have a hyperlink like the other two items. Is it intentional?


Reply via ReviewNB

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The hyperlink is not existed now and pending for new doc populated after the fixing.

@@ -0,0 +1,483 @@
{
Copy link
Contributor

@sycai sycai Apr 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: "... while keeping other columns"


Reply via ReviewNB

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@chelsea-lin chelsea-lin requested a review from sycai April 23, 2025 01:26
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

array is mispelled. You have 3 rs.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catches. Thanks!

@chelsea-lin chelsea-lin force-pushed the main_chelsealin_jsonnotebook branch from 4bd0397 to 38eac9c Compare April 23, 2025 17:04
@chelsea-lin chelsea-lin requested a review from tswast April 23, 2025 17:52
@chelsea-lin
Copy link
Contributor Author

The tests/system/small/functions/test_remote_function.py::test_skip_bq_connection_check test failed in presubmit tests, but it does not seem related to this change.

@chelsea-lin chelsea-lin added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 23, 2025
@chelsea-lin chelsea-lin enabled auto-merge (squash) April 23, 2025 21:30
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 23, 2025
@bigframes-bot bigframes-bot removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 23, 2025
@chelsea-lin chelsea-lin force-pushed the main_chelsealin_jsonnotebook branch from 2c21739 to 403ad09 Compare April 23, 2025 21:39
@chelsea-lin chelsea-lin disabled auto-merge April 23, 2025 21:49
@chelsea-lin chelsea-lin force-pushed the main_chelsealin_jsonnotebook branch from 403ad09 to 8b7f2c7 Compare April 24, 2025 20:04
@chelsea-lin chelsea-lin enabled auto-merge (squash) April 24, 2025 20:04
@chelsea-lin chelsea-lin merged commit 9128c4a into main Apr 24, 2025
17 of 24 checks passed
@chelsea-lin chelsea-lin deleted the main_chelsealin_jsonnotebook branch April 24, 2025 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: xl Pull request size is extra large.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants