Skip to content

Conversation

shobsi
Copy link
Contributor

@shobsi shobsi commented Apr 16, 2025

This change will force the user to provide a dataset and name for the BigQuery managed python udf created through BigFrames, for easy discovery and cleanup when necessary.

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes internal issue 409580589 🦕

This change will force the user to provide a dataset and name for the
BigQuery managed python udf created through BigFrames, for easy
discovery and cleanup when necessary.
@shobsi shobsi requested review from a team as code owners April 16, 2025 00:23
@shobsi shobsi requested a review from Genesis929 April 16, 2025 00:23
@product-auto-label product-auto-label bot added the size: m Pull request size is medium. label Apr 16, 2025
@product-auto-label product-auto-label bot added the api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. label Apr 16, 2025
@shobsi shobsi requested review from tswast and jialuoo April 16, 2025 00:23
@GarrettWu GarrettWu removed their assignment Apr 16, 2025
@tswast tswast changed the title chore!: make dataset and name params mandatory in udf fix!: make dataset and name params mandatory in udf Apr 16, 2025
@tswast
Copy link
Collaborator

tswast commented Apr 16, 2025

@shobsi we should not use chore for things that should be visible to the user in the changelog. I've renamed to fix.

@tswast tswast merged commit 637e860 into main Apr 16, 2025
24 checks passed
@tswast tswast deleted the shobs-udf-force-named branch April 16, 2025 14:20
@shobsi
Copy link
Contributor Author

shobsi commented Apr 16, 2025

@shobsi we should not use chore for things that should be visible to the user in the changelog. I've renamed to fix.

Wouldn't the ! make it visible under BREAKING CHANGES?

@tswast
Copy link
Collaborator

tswast commented Apr 17, 2025

Those two things really shouldn't be mixed. chore: implies this isn't something that should affect the user, but this clearly does.

See https://github.com/googleapis/release-please/blob/422df5a6a9d44a52c6c682563d1795b8fd246215/src/strategies/python.ts#L31-L44 for options.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: m Pull request size is medium.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants