Skip to content

chore: remove discontinued sqlglot type attribute from the vendored ibis code #1379

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sycai merged 2 commits into from
Feb 10, 2025
Merged

chore: remove discontinued sqlglot type attribute from the vendored ibis code #1379

sycai merged 2 commits into from
Feb 10, 2025

Conversation

@shobsi
Copy link
Contributor

@shobsi shobsi commented Feb 8, 2025 •
edited
Loading

The type attribute UNIQUEIDENTIFIER has been removed in sqlglot head
tobymao/sqlglot@b12aba9#diff-7857fedd1d1451b1b9a5b8efaa1cc292c02e7ee4f0d04d7e2f9d5bfb9565802c which is causing unit_prerelease tests fail with AttributeError: type object 'Type' has no attribute 'UNIQUEIDENTIFIER':

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes internal issue 395193422 🦕

@shobsi shobsi requested review from a team as code owners February 8, 2025 02:47
@shobsi shobsi requested a review from TrevorBergeron February 8, 2025 02:47
@product-auto-label product-auto-label bot added the size: xs Pull request size is extra small. label Feb 8, 2025
@product-auto-label product-auto-label bot added the api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. label Feb 8, 2025
@shobsi shobsi changed the title chore: remove UNIQUEIDENTIFIER from the vendored ibis datatypes chore: remove discontinued sqlglot type attribute from the vendored ibis datatypes Feb 8, 2025
@shobsi shobsi changed the title chore: remove discontinued sqlglot type attribute from the vendored ibis datatypes chore: remove discontinued sqlglot type attribute from the vendored ibis code Feb 8, 2025
@sycai sycai merged commit 24962cd into main Feb 10, 2025
17 of 23 checks passed
@sycai sycai deleted the shobs-UNIQUEIDENTIFIER branch February 10, 2025 20:53
shuoweil pushed a commit that referenced this pull request Feb 10, 2025
@shobsi @shuoweil
remove UNIQUEIDENTIFIER from the vendored ibis datatypes (#1379)
2b79635 
This type has been removed in sqlglot head
tobymao/sqlglot@b12aba9#diff-7857fedd1d1451b1b9a5b8efaa1cc292c02e7ee4f0d04d7e2f9d5bfb9565802c.
@hellowin hellowin mentioned this pull request Feb 11, 2025
Closed
@Genesis929 Genesis929 mentioned this pull request Feb 11, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sycai sycai sycai approved these changes

@TrevorBergeron TrevorBergeron Awaiting requested review from TrevorBergeron TrevorBergeron is a code owner automatically assigned from googleapis/api-bigquery-dataframe

Assignees

@arwas11 arwas11

Labels

api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: xs Pull request size is extra small.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@shobsi @sycai @arwas11