make ibis runable

Author: chelsea-lin

bigframes/core/compile/sqlglot/aggregations/unary_compiler.py

@@ -245,10 +245,11 @@ def _cut_ops_w_intervals(
                 value = sge.Struct(
                     expressions=[
                         sge.PropertyEQ(
-                            this=sge.Identifier(this="left_exclusive"), expression=left
+                            this=sge.Identifier(this="left_exclusive", quoted=True),
+                            expression=left,
                         ),
                         sge.PropertyEQ(
-                            this=sge.Identifier(this="right_inclusive"),
+                            this=sge.Identifier(this="right_inclusive", quoted=True),
                             expression=right,
                         ),
                     ]
@@ -257,10 +258,11 @@ def _cut_ops_w_intervals(
                 value = sge.Struct(
                     expressions=[
                         sge.PropertyEQ(
-                            this=sge.Identifier(this="left_inclusive"), expression=left
+                            this=sge.Identifier(this="left_inclusive", quoted=True),
+                            expression=left,
                         ),
                         sge.PropertyEQ(
-                            this=sge.Identifier(this="right_exclusive"),
+                            this=sge.Identifier(this="right_exclusive", quoted=True),
                             expression=right,
                         ),
                     ]

…ots/test_unary_compiler/test_cut/out.sql …est_unary_compiler/test_cut/int_bins.sqltests/unit/core/compile/sqlglot/aggregations/snapshots/test_unary_compiler/test_cut/out.sql renamed to tests/unit/core/compile/sqlglot/aggregations/snapshots/test_unary_compiler/test_cut/int_bins.sql tests/unit/core/compile/sqlglot/aggregations/snapshots/test_unary_compiler/test_cut/out.sql renamed to tests/unit/core/compile/sqlglot/aggregations/snapshots/test_unary_compiler/test_cut/int_bins.sql

@@ -4,6 +4,7 @@ WITH `bfcte_0` AS (
   FROM `bigframes-dev`.`sqlglot_test`.`scalar_types`
 ), `bfcte_1` AS (
   SELECT
+    *,
     CASE
       WHEN `int64_col` <= MIN(`int64_col`) OVER () + (
         1 * IEEE_DIVIDE(MAX(`int64_col`) OVER () - MIN(`int64_col`) OVER (), 3)
@@ -46,36 +47,9 @@ WITH `bfcte_0` AS (
           3 * IEEE_DIVIDE(MAX(`int64_col`) OVER () - MIN(`int64_col`) OVER (), 3)
         ) + 0 AS `right_inclusive`
       )
-    END AS `bfcol_1`,
-    CASE
-      WHEN `int64_col` > 0 AND `int64_col` <= 1
-      THEN STRUCT(0 AS left_exclusive, 1 AS right_inclusive)
-      WHEN `int64_col` > 1 AND `int64_col` <= 2
-      THEN STRUCT(1 AS left_exclusive, 2 AS right_inclusive)
-    END AS `bfcol_2`,
-    CASE
-      WHEN `int64_col` < MIN(`int64_col`) OVER () + (
-        1 * IEEE_DIVIDE(MAX(`int64_col`) OVER () - MIN(`int64_col`) OVER (), 3)
-      )
-      THEN 'a'
-      WHEN `int64_col` < MIN(`int64_col`) OVER () + (
-        2 * IEEE_DIVIDE(MAX(`int64_col`) OVER () - MIN(`int64_col`) OVER (), 3)
-      )
-      THEN 'b'
-      WHEN `int64_col` IS NOT NULL
-      THEN 'c'
-    END AS `bfcol_3`,
-    CASE
-      WHEN `int64_col` > 0 AND `int64_col` <= 1
-      THEN 0
-      WHEN `int64_col` > 1 AND `int64_col` <= 2
-      THEN 1
-    END AS `bfcol_4`
+    END OVER () AS `bfcol_1`
   FROM `bfcte_0`
 )
 SELECT
-  `bfcol_1` AS `int_bins`,
-  `bfcol_2` AS `interval_bins`,
-  `bfcol_3` AS `int_bins_labels`,
-  `bfcol_4` AS `interval_bins_labels`
+  `bfcol_1` AS `int_bins`
 FROM `bfcte_1`

tests/unit/core/compile/sqlglot/aggregations/snapshots/test_unary_compiler/test_cut/int_bins_labels.sql

@@ -0,0 +1,24 @@
+WITH `bfcte_0` AS (
+  SELECT
+    `int64_col`
+  FROM `bigframes-dev`.`sqlglot_test`.`scalar_types`
+), `bfcte_1` AS (
+  SELECT
+    *,
+    CASE
+      WHEN `int64_col` < MIN(`int64_col`) OVER () + (
+        1 * IEEE_DIVIDE(MAX(`int64_col`) OVER () - MIN(`int64_col`) OVER (), 3)
+      )
+      THEN 'a'
+      WHEN `int64_col` < MIN(`int64_col`) OVER () + (
+        2 * IEEE_DIVIDE(MAX(`int64_col`) OVER () - MIN(`int64_col`) OVER (), 3)
+      )
+      THEN 'b'
+      WHEN `int64_col` IS NOT NULL
+      THEN 'c'
+    END OVER () AS `bfcol_1`
+  FROM `bfcte_0`
+)
+SELECT
+  `bfcol_1` AS `int_bins_labels`
+FROM `bfcte_1`

tests/unit/core/compile/sqlglot/aggregations/snapshots/test_unary_compiler/test_cut/interval_bins.sql

@@ -0,0 +1,18 @@
+WITH `bfcte_0` AS (
+  SELECT
+    `int64_col`
+  FROM `bigframes-dev`.`sqlglot_test`.`scalar_types`
+), `bfcte_1` AS (
+  SELECT
+    *,
+    CASE
+      WHEN `int64_col` > 0 AND `int64_col` <= 1
+      THEN STRUCT(0 AS `left_exclusive`, 1 AS `right_inclusive`)
+      WHEN `int64_col` > 1 AND `int64_col` <= 2
+      THEN STRUCT(1 AS `left_exclusive`, 2 AS `right_inclusive`)
+    END OVER () AS `bfcol_1`
+  FROM `bfcte_0`
+)
+SELECT
+  `bfcol_1` AS `interval_bins`
+FROM `bfcte_1`

tests/unit/core/compile/sqlglot/aggregations/snapshots/test_unary_compiler/test_cut/interval_bins_labels.sql

@@ -0,0 +1,18 @@
+WITH `bfcte_0` AS (
+  SELECT
+    `int64_col`
+  FROM `bigframes-dev`.`sqlglot_test`.`scalar_types`
+), `bfcte_1` AS (
+  SELECT
+    *,
+    CASE
+      WHEN `int64_col` > 0 AND `int64_col` <= 1
+      THEN 0
+      WHEN `int64_col` > 1 AND `int64_col` <= 2
+      THEN 1
+    END OVER () AS `bfcol_1`
+  FROM `bfcte_0`
+)
+SELECT
+  `bfcol_1` AS `interval_bins_labels`
+FROM `bfcte_1`

tests/unit/core/compile/sqlglot/aggregations/test_unary_compiler.py

@@ -194,11 +194,13 @@ def test_cut(scalar_types_df: bpd.DataFrame, snapshot):
             expression.deref(col_name),
         ),
     }
-    sql = _apply_unary_agg_ops(
-        bf_df, list(agg_ops_map.values()), list(agg_ops_map.keys())
-    )
+    window = window_spec.WindowSpec()
 
-    snapshot.assert_match(sql, "out.sql")
+    # Loop through the aggregation map items
+    for test_name, agg_expr in agg_ops_map.items():
+        sql = _apply_unary_window_op(bf_df, agg_expr, window, test_name)
+        
+        snapshot.assert_match(sql, f"{test_name}.sql")
 
 
 def test_dense_rank(scalar_types_df: bpd.DataFrame, snapshot):