Skip to content

fix: add warning to retry target to avoid incorrect usage #543

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Nov 3, 2023
Merged

fix: add warning to retry target to avoid incorrect usage #543

merged 4 commits into from
Nov 3, 2023

Conversation

ohmayr
Copy link
Contributor

@ohmayr ohmayr commented Oct 26, 2023

Fixes #542 🦕

@ohmayr ohmayr requested review from a team as code owners October 26, 2023 01:07
@product-auto-label product-auto-label bot added the size: xs Pull request size is extra small. label Oct 26, 2023
@ohmayr ohmayr force-pushed the add-warning-to-retry branch 5 times, most recently from 29a7c83 to f5eb290 Compare October 26, 2023 19:51
@product-auto-label product-auto-label bot added size: s Pull request size is small. and removed size: xs Pull request size is extra small. labels Oct 26, 2023
@ohmayr ohmayr changed the title add warning to retry_target to avoid incorrect usage add warning to retry target to avoid incorrect usage Oct 26, 2023
@ohmayr ohmayr changed the title add warning to retry target to avoid incorrect usage fix: add warning to retry target to avoid incorrect usage Oct 26, 2023
@ohmayr ohmayr force-pushed the add-warning-to-retry branch 6 times, most recently from 95bcc0f to 12d5c35 Compare October 27, 2023 00:22
vchudnov-g
vchudnov-g reviewed Oct 27, 2023
View reviewed changes
@ohmayr ohmayr force-pushed the add-warning-to-retry branch 2 times, most recently from 4e04b7d to 11b5e02 Compare October 27, 2023 17:21
vchudnov-g
vchudnov-g requested changes Oct 27, 2023
View reviewed changes
Copy link
Contributor

@vchudnov-g vchudnov-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's looking good, but just a few questions/comments.

@ohmayr ohmayr force-pushed the add-warning-to-retry branch from 934fa4a to 663fb2f Compare October 30, 2023 02:03
@ohmayr ohmayr force-pushed the add-warning-to-retry branch from 4675b44 to 5cdba7b Compare November 3, 2023 16:40
vchudnov-g
vchudnov-g approved these changes Nov 3, 2023
View reviewed changes
@ohmayr ohmayr force-pushed the add-warning-to-retry branch from 08c22b3 to 08ddc27 Compare November 3, 2023 17:14
@ohmayr ohmayr merged commit bfb40e6 into main Nov 3, 2023
@ohmayr ohmayr deleted the add-warning-to-retry branch November 3, 2023 19:30
@release-please release-please bot mentioned this pull request Nov 3, 2023
Merged
@daniel-sanche daniel-sanche mentioned this pull request May 3, 2024
Merged
This was referenced May 30, 2025
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vchudnov-g vchudnov-g vchudnov-g approved these changes

Assignees
No one assigned
Labels
size: s Pull request size is small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Raise a warning in google.api_core.retry.retry_target if the return value is awaitable
2 participants
@ohmayr @vchudnov-g