fix: include COLUMN_DEFAULT in the returned metadata #1937
Merged
+112
−32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Include the COLUMN_DEFAULT value in the DatabaseMetaData that is returned for the getColumns() method. These were missing, as Spanner previously did not support default values.
product-auto-label
bot
added
size: m
olavloite
added a commit
to cloudspannerecosystem/liquibase-spanner
that referenced
this pull request
Feb 27, 2025
The Spanner Liquibase provider executes an extra query to get the column default value, as the Spanner JDBC driver does not include that in the metadata it returns. This will be fixed in googleapis/java-spanner-jdbc#1937
olavloite
added a commit
to cloudspannerecosystem/liquibase-spanner
that referenced
this pull request
Feb 27, 2025
The Spanner Liquibase provider executes an extra query to get the column default value, as the Spanner JDBC driver does not include that in the metadata it returns. This will be fixed in googleapis/java-spanner-jdbc#1937
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Include the COLUMN_DEFAULT value in the DatabaseMetaData that is returned for the getColumns() method. These were missing, as Spanner previously did not support default values.