-
Notifications
You must be signed in to change notification settings - Fork 75
fix: BulkWriter flush logic #1778
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use -- conventional-commit-lint bot |
milaGGL
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thank you Tom.
|
I've tested this a few times, and it still hangs occasionally. I'd have to add more logging to figure out where things went off the rails... :( |
|
@tom-andersen Any chance there is a similar issue in the JS version of |
Should fix: #1772