Skip to content

Conversation

@tom-andersen
Copy link
Contributor

@tom-andersen tom-andersen commented Aug 2, 2024

Should fix: #1772

@product-auto-label product-auto-label bot added size: s Pull request size is small. api: firestore Issues related to the googleapis/java-firestore API. labels Aug 2, 2024
@tom-andersen tom-andersen changed the title Fix race condition fix: BulkWriter flush logic Aug 3, 2024
@conventional-commit-lint-gcf
Copy link

conventional-commit-lint-gcf bot commented Aug 3, 2024

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

@tom-andersen tom-andersen requested a review from milaGGL August 3, 2024 00:06
@tom-andersen tom-andersen marked this pull request as ready for review August 3, 2024 00:08
@tom-andersen tom-andersen requested a review from a team as a code owner August 3, 2024 00:08
@tom-andersen tom-andersen added the kokoro:run Add this label to force Kokoro to re-run the tests. label Aug 3, 2024
@product-auto-label product-auto-label bot added size: m Pull request size is medium. and removed size: s Pull request size is small. labels Aug 3, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Aug 3, 2024
Copy link
Contributor

@milaGGL milaGGL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you Tom.

@thewildllama
Copy link

I've tested this a few times, and it still hangs occasionally. I'd have to add more logging to figure out where things went off the rails... :(

@tom-andersen tom-andersen merged commit 627619d into main Dec 4, 2024
@tom-andersen tom-andersen deleted the tomandersen/flushBulkWriter branch December 4, 2024 14:54
@bdaz
Copy link

bdaz commented Sep 17, 2025

@tom-andersen Any chance there is a similar issue in the JS version of BulkWriter? I am seeing the same behavior, where all writes actually succeed, but flush() (or close()) hang.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: firestore Issues related to the googleapis/java-firestore API. size: m Pull request size is medium.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

firestore.BulkWriter.flush() has a race

5 participants