use at least 1 Junit38 test

Author: diegomarquezp

google-http-client/src/test/java/com/google/api/client/http/HttpRequestTest.java

@@ -14,13 +14,6 @@
 
 package com.google.api.client.http;
 
-import static org.junit.Assert.assertEquals;
-import static org.junit.Assert.assertFalse;
-import static org.junit.Assert.assertNotNull;
-import static org.junit.Assert.assertNull;
-import static org.junit.Assert.assertTrue;
-import static org.junit.Assert.fail;
-
 import com.google.api.client.testing.http.HttpTesting;
 import com.google.api.client.testing.http.MockHttpTransport;
 import com.google.api.client.testing.http.MockHttpUnsuccessfulResponseHandler;
@@ -61,26 +54,25 @@
  *
  * @author Yaniv Inbar
  */
-public class HttpRequestTest {
+public class HttpRequestTest extends TestCase {
 
   private static final ImmutableSet<String> BASIC_METHODS =
       ImmutableSet.of(HttpMethods.GET, HttpMethods.PUT, HttpMethods.POST, HttpMethods.DELETE);
   private static final ImmutableSet<String> OTHER_METHODS =
       ImmutableSet.of(HttpMethods.HEAD, HttpMethods.PATCH);
 
-  @Before
+  @Override
   public void setUp() {
     // suppress logging warnings to the console
     HttpTransport.LOGGER.setLevel(java.util.logging.Level.SEVERE);
   }
 
-  @After
+  @Override
   public void tearDown() {
     // back to the standard logging level for console
     HttpTransport.LOGGER.setLevel(java.util.logging.Level.WARNING);
   }
 
-  @Test
   public void testNotSupportedByDefault() throws Exception {
     MockHttpTransport transport = new MockHttpTransport();
     HttpRequest request =
@@ -119,7 +111,6 @@ public void execute(Runnable command) {
     }
   }
 
-  @Deprecated
   private static class MockBackOffPolicy implements BackOffPolicy {
 
     int backOffCalls;
@@ -211,7 +202,6 @@ public boolean handleResponse(
         });
   }
 
-  @Test
   public void test301Redirect() throws Exception {
     // Set up RedirectTransport to redirect on the first request and then return success.
     RedirectTransport fakeTransport = new RedirectTransport();
@@ -224,7 +214,6 @@ public void test301Redirect() throws Exception {
   }
 
   @Deprecated
-  @Test
   public void test301RedirectWithUnsuccessfulResponseHandled() throws Exception {
     MockHttpUnsuccessfulResponseHandler handler = new MockHttpUnsuccessfulResponseHandler(true);
     MockBackOffPolicy backOffPolicy = new MockBackOffPolicy();
@@ -248,7 +237,6 @@ public void test301RedirectWithUnsuccessfulResponseHandled() throws Exception {
     assertTrue(handler.isCalled());
   }
 
-  @Test
   public void test301RedirectWithBackOffUnsuccessfulResponseHandled() throws Exception {
     MockHttpUnsuccessfulResponseHandler handler = new MockHttpUnsuccessfulResponseHandler(true);
     // Set up RedirectTransport to redirect on the first request and then return success.
@@ -295,7 +283,6 @@ public void test301RedirectWithUnsuccessfulResponseNotHandled() throws Exception
     assertEquals(0, backOffPolicy.backOffCalls);
   }
 
-  @Test
   public void test301RedirectWithBackOffUnsuccessfulResponseNotHandled() throws Exception {
     // Create an Unsuccessful response handler that always returns false.
     MockHttpUnsuccessfulResponseHandler handler = new MockHttpUnsuccessfulResponseHandler(false);
@@ -318,7 +305,6 @@ public void test301RedirectWithBackOffUnsuccessfulResponseNotHandled() throws Ex
     assertEquals(0, backOff.getNumberOfTries());
   }
 
-  @Test
   public void test303Redirect() throws Exception {
     // Set up RedirectTransport to redirect on the first request and then return success.
     RedirectTransport fakeTransport = new RedirectTransport();
@@ -341,7 +327,6 @@ public void test303Redirect() throws Exception {
     assertNull(request.getContent());
   }
 
-  @Test
   public void testInfiniteRedirects() throws Exception {
     // Set up RedirectTransport to cause infinite redirections.
     RedirectTransport fakeTransport = new RedirectTransport();
@@ -359,7 +344,6 @@ public void testInfiniteRedirects() throws Exception {
     assertEquals(request.getNumberOfRetries() + 1, fakeTransport.lowLevelExecCalls);
   }
 
-  @Test
   public void testMissingLocationRedirect() throws Exception {
     // Set up RedirectTransport to set responses with missing location headers.
     RedirectTransport fakeTransport = new RedirectTransport();
@@ -469,7 +453,6 @@ public LowLevelHttpRequest buildRequest(String method, String url) {
     }
   }
 
-  @Test
   public void testHandleRedirect() throws Exception {
     StatusCodesTransport transport = new StatusCodesTransport();
     HttpRequest req =
@@ -524,7 +507,6 @@ private void subtestRedirect(int statusCode, boolean setLocation) throws Excepti
     }
   }
 
-  @Test
   public void testHandleRedirect_relativeLocation() throws IOException {
     subtestHandleRedirect_relativeLocation("http://some.org/a/b", "z", "http://some.org/a/z");
     subtestHandleRedirect_relativeLocation("http://some.org/a/b", "z/", "http://some.org/a/z/");
@@ -544,7 +526,6 @@ public void subtestHandleRedirect_relativeLocation(
   }
 
   @Deprecated
-  @Test
   public void testExecuteErrorWithRetryEnabled() throws Exception {
     int callsBeforeSuccess = 3;
     FailThenSuccessConnectionErrorTransport fakeTransport =
@@ -559,7 +540,6 @@ public void testExecuteErrorWithRetryEnabled() throws Exception {
     assertEquals(4, fakeTransport.lowLevelExecCalls);
   }
 
-  @Test
   public void testExecuteErrorWithIOExceptionHandler() throws Exception {
     int callsBeforeSuccess = 3;
     FailThenSuccessConnectionErrorTransport fakeTransport =
@@ -575,7 +555,6 @@ public void testExecuteErrorWithIOExceptionHandler() throws Exception {
   }
 
   @Deprecated
-  @Test
   public void testExecuteErrorWithRetryEnabledBeyondRetryLimit() throws Exception {
     int callsBeforeSuccess = 11;
     FailThenSuccessConnectionErrorTransport fakeTransport =
@@ -593,7 +572,6 @@ public void testExecuteErrorWithRetryEnabledBeyondRetryLimit() throws Exception
     assertEquals(callsBeforeSuccess, fakeTransport.lowLevelExecCalls);
   }
 
-  @Test
   public void testExecuteErrorWithIOExceptionHandlerBeyondRetryLimit() throws Exception {
     int callsBeforeSuccess = 11;
     FailThenSuccessConnectionErrorTransport fakeTransport =
@@ -611,7 +589,6 @@ public void testExecuteErrorWithIOExceptionHandlerBeyondRetryLimit() throws Exce
     assertEquals(callsBeforeSuccess, fakeTransport.lowLevelExecCalls);
   }
 
-  @Test
   public void testExecuteErrorWithoutIOExceptionHandler() throws Exception {
     int callsBeforeSuccess = 3;
     FailThenSuccessConnectionErrorTransport fakeTransport =
@@ -630,7 +607,6 @@ public void testExecuteErrorWithoutIOExceptionHandler() throws Exception {
   }
 
   @Deprecated
-  @Test
   public void testUserAgentWithExecuteErrorAndRetryEnabled() throws Exception {
     int callsBeforeSuccess = 3;
     FailThenSuccessConnectionErrorTransport fakeTransport =
@@ -647,7 +623,6 @@ public void testUserAgentWithExecuteErrorAndRetryEnabled() throws Exception {
     assertEquals(4, fakeTransport.lowLevelExecCalls);
   }
 
-  @Test
   public void testUserAgentWithExecuteErrorAndIOExceptionHandler() throws Exception {
     int callsBeforeSuccess = 3;
     FailThenSuccessConnectionErrorTransport fakeTransport =
@@ -664,7 +639,6 @@ public void testUserAgentWithExecuteErrorAndIOExceptionHandler() throws Exceptio
     assertEquals(4, fakeTransport.lowLevelExecCalls);
   }
 
-  @Test
   public void testAbnormalResponseHandlerWithNoBackOff() throws Exception {
     FailThenSuccessBackoffTransport fakeTransport =
         new FailThenSuccessBackoffTransport(HttpStatusCodes.STATUS_CODE_UNAUTHORIZED, 1);
@@ -681,7 +655,6 @@ public void testAbnormalResponseHandlerWithNoBackOff() throws Exception {
   }
 
   @Deprecated
-  @Test
   public void testAbnormalResponseHandlerWithBackOff() throws Exception {
     FailThenSuccessBackoffTransport fakeTransport =
         new FailThenSuccessBackoffTransport(HttpStatusCodes.STATUS_CODE_SERVER_ERROR, 1);
@@ -701,7 +674,6 @@ public void testAbnormalResponseHandlerWithBackOff() throws Exception {
     assertTrue(handler.isCalled());
   }
 
-  @Test
   public void testAbnormalResponseHandlerWithBackOffUnsuccessfulResponseHandler() throws Exception {
     FailThenSuccessBackoffTransport fakeTransport =
         new FailThenSuccessBackoffTransport(HttpStatusCodes.STATUS_CODE_SERVER_ERROR, 1);
@@ -720,7 +692,6 @@ public void testAbnormalResponseHandlerWithBackOffUnsuccessfulResponseHandler()
   }
 
   @Deprecated
-  @Test
   public void testBackOffSingleCall() throws Exception {
     FailThenSuccessBackoffTransport fakeTransport =
         new FailThenSuccessBackoffTransport(HttpStatusCodes.STATUS_CODE_SERVER_ERROR, 1);
@@ -740,7 +711,6 @@ public void testBackOffSingleCall() throws Exception {
     assertTrue(handler.isCalled());
   }
 
-  @Test
   public void testBackOffUnsuccessfulResponseSingleCall() throws Exception {
     FailThenSuccessBackoffTransport fakeTransport =
         new FailThenSuccessBackoffTransport(HttpStatusCodes.STATUS_CODE_SERVER_ERROR, 1);
@@ -759,7 +729,6 @@ public void testBackOffUnsuccessfulResponseSingleCall() throws Exception {
   }
 
   @Deprecated
-  @Test
   public void testBackOffMultipleCalls() throws Exception {
     int callsBeforeSuccess = 5;
     FailThenSuccessBackoffTransport fakeTransport =
@@ -781,7 +750,6 @@ public void testBackOffMultipleCalls() throws Exception {
     assertTrue(handler.isCalled());
   }
 
-  @Test
   public void testBackOffUnsucessfulReponseMultipleCalls() throws Exception {
     int callsBeforeSuccess = 5;
     FailThenSuccessBackoffTransport fakeTransport =
@@ -802,7 +770,6 @@ public void testBackOffUnsucessfulReponseMultipleCalls() throws Exception {
   }
 
   @Deprecated
-  @Test
   public void testBackOffCallsBeyondRetryLimit() throws Exception {
     int callsBeforeSuccess = 11;
     FailThenSuccessBackoffTransport fakeTransport =
@@ -827,7 +794,6 @@ public void testBackOffCallsBeyondRetryLimit() throws Exception {
     assertTrue(handler.isCalled());
   }
 
-  @Test
   public void testBackOffUnsuccessfulReponseCallsBeyondRetryLimit() throws Exception {
     int callsBeforeSuccess = 11;
     FailThenSuccessBackoffTransport fakeTransport =
@@ -851,7 +817,6 @@ public void testBackOffUnsuccessfulReponseCallsBeyondRetryLimit() throws Excepti
   }
 
   @Deprecated
-  @Test
   public void testBackOffUnRecognizedStatusCode() throws Exception {
     FailThenSuccessBackoffTransport fakeTransport =
         new FailThenSuccessBackoffTransport(HttpStatusCodes.STATUS_CODE_UNAUTHORIZED, 1);
@@ -874,7 +839,6 @@ public void testBackOffUnRecognizedStatusCode() throws Exception {
     assertTrue(handler.isCalled());
   }
 
-  @Test
   public void testBackOffUnsuccessfulReponseUnRecognizedStatusCode() throws Exception {
     FailThenSuccessBackoffTransport fakeTransport =
         new FailThenSuccessBackoffTransport(HttpStatusCodes.STATUS_CODE_UNAUTHORIZED, 1);
@@ -896,7 +860,6 @@ public void testBackOffUnsuccessfulReponseUnRecognizedStatusCode() throws Except
   }
 
   @Deprecated
-  @Test
   public void testBackOffStop() throws Exception {
     int callsBeforeSuccess = 5;
     FailThenSuccessBackoffTransport fakeTransport =
@@ -923,7 +886,6 @@ public void testBackOffStop() throws Exception {
     assertTrue(handler.isCalled());
   }
 
-  @Test
   public void testBackOffUnsucessfulResponseStop() throws Exception {
     int callsBeforeSuccess = 5;
     FailThenSuccessBackoffTransport fakeTransport =
@@ -970,7 +932,6 @@ public static class MyHeaders extends HttpHeaders {
     @Key E otherValue;
   }
 
-  @Test
   public void testExecute_headerSerialization() throws Exception {
     // custom headers
     MyHeaders myHeaders = new MyHeaders();
@@ -1011,7 +972,6 @@ public LowLevelHttpRequest buildRequest(String method, String url) throws IOExce
     assertEquals(ImmutableList.of("other"), lowLevelRequest.getHeaderValues("othervalue"));
   }
 
-  @Test
   public void testGZipEncoding() throws Exception {
     class MyTransport extends MockHttpTransport {
 
@@ -1061,7 +1021,6 @@ public LowLevelHttpResponse execute() throws IOException {
     request.execute();
   }
 
-  @Test
   public void testContentLoggingLimitWithLoggingEnabledAndDisabled() throws Exception {
 
     class MyTransport extends MockHttpTransport {
@@ -1128,20 +1087,17 @@ public LowLevelHttpResponse execute() throws IOException {
     }
   }
 
-  @Test
   public void testVersion() {
     assertNotNull("version constant should not be null", HttpRequest.VERSION);
     Pattern semverPattern = Pattern.compile("\\d+\\.\\d+\\.\\d+(-sp\\.\\d+)?(-SNAPSHOT)?");
     assertTrue(semverPattern.matcher(HttpRequest.VERSION).matches());
   }
 
-  @Test
   public void testUserAgent() {
     assertTrue(HttpRequest.USER_AGENT_SUFFIX.contains("Google-HTTP-Java-Client"));
     assertTrue(HttpRequest.USER_AGENT_SUFFIX.contains("gzip"));
   }
 
-  @Test
   public void testExecute_headers() throws Exception {
     HttpTransport transport = new MockHttpTransport();
     HttpRequest request =
@@ -1151,7 +1107,6 @@ public void testExecute_headers() throws Exception {
     request.execute();
   }
 
-  @Test
   public void testSuppressUserAgentSuffix() throws Exception {
     class MyTransport extends MockHttpTransport {
       String expectedUserAgent;
@@ -1194,7 +1149,6 @@ public LowLevelHttpResponse execute() throws IOException {
     request.execute();
   }
 
-  @Test
   public void testExecuteAsync()
       throws IOException, InterruptedException, ExecutionException, TimeoutException {
     MockExecutor mockExecutor = new MockExecutor();
@@ -1209,7 +1163,6 @@ public void testExecuteAsync()
     assertNotNull(futureResponse.get(10, TimeUnit.MILLISECONDS));
   }
 
-  @Test
   public void testExecute_redirects() throws Exception {
     class MyTransport extends MockHttpTransport {
       int count = 1;
@@ -1240,7 +1193,6 @@ public LowLevelHttpRequest buildRequest(String method, String url) throws IOExce
     }
   }
 
-  @Test
   public void testExecute_redirectWithIncorrectContentRetryableSetting() throws Exception {
     // TODO(yanivi): any way we can warn user about this?
     RedirectTransport fakeTransport = new RedirectTransport();
@@ -1261,7 +1213,6 @@ public void testExecute_redirectWithIncorrectContentRetryableSetting() throws Ex
     assertEquals(2, fakeTransport.lowLevelExecCalls);
   }
 
-  @Test
   public void testExecute_curlLogger() throws Exception {
     LogRecordingHandler recorder = new LogRecordingHandler();
     HttpTransport.LOGGER.setLevel(Level.CONFIG);
@@ -1284,7 +1235,6 @@ public void testExecute_curlLogger() throws Exception {
     assertTrue(found);
   }
 
-  @Test
   public void testExecute_curlLoggerWithContentEncoding() throws Exception {
     LogRecordingHandler recorder = new LogRecordingHandler();
     HttpTransport.LOGGER.setLevel(Level.CONFIG);
@@ -1318,7 +1268,6 @@ public void testExecute_curlLoggerWithContentEncoding() throws Exception {
     assertTrue(found);
   }
 
-  @Test
   public void testVersion_matchesAcceptablePatterns() throws Exception {
     String acceptableVersionPattern =
         "unknown-version|(?:\\d+\\.\\d+\\.\\d+(?:-.*?)?(?:-SNAPSHOT)?)";