Use shared RFC 3339 timestamp format string in storage.

Author: tseaver

gcloud/storage/blob.py

@@ -34,10 +34,10 @@
 from gcloud.storage._helpers import _scalar_property
 from gcloud.storage import _implicit_environ
 from gcloud.storage.acl import ObjectACL
+from gcloud._helpers import _RFC3339_MICROS
 
 
 _API_ACCESS_ENDPOINT = 'https://storage.googleapis.com'
-_GOOGLE_TIMESTAMP_FORMAT = '%Y-%m-%dT%H:%M:%S.%fZ'
 
 
 class Blob(_PropertyMixin):
@@ -695,7 +695,7 @@ def time_deleted(self):
         """
         value = self._properties.get('timeDeleted')
         if value is not None:
-            return datetime.datetime.strptime(value, _GOOGLE_TIMESTAMP_FORMAT)
+            return datetime.datetime.strptime(value, _RFC3339_MICROS)
 
     @property
     def updated(self):
@@ -709,7 +709,7 @@ def updated(self):
         """
         value = self._properties.get('updated')
         if value is not None:
-            return datetime.datetime.strptime(value, _GOOGLE_TIMESTAMP_FORMAT)
+            return datetime.datetime.strptime(value, _RFC3339_MICROS)
 
 
 class _UploadConfig(object):

gcloud/storage/bucket.py

@@ -46,7 +46,7 @@
 from gcloud.storage.acl import DefaultObjectACL
 from gcloud.storage.iterator import Iterator
 from gcloud.storage.blob import Blob
-from gcloud.storage.blob import _GOOGLE_TIMESTAMP_FORMAT
+from gcloud._helpers import _RFC3339_MICROS
 
 
 class _BlobIterator(Iterator):
@@ -692,7 +692,7 @@ def time_created(self):
         """
         value = self._properties.get('timeCreated')
         if value is not None:
-            return datetime.datetime.strptime(value, _GOOGLE_TIMESTAMP_FORMAT)
+            return datetime.datetime.strptime(value, _RFC3339_MICROS)
 
     @property
     def versioning_enabled(self):

gcloud/storage/test_blob.py

@@ -1041,11 +1041,12 @@ def test_storage_class(self):
 
     def test_time_deleted(self):
         import datetime
+        from gcloud._helpers import _RFC3339_MICROS
         BLOB_NAME = 'blob-name'
         connection = _Connection()
         bucket = _Bucket(connection)
         TIMESTAMP = datetime.datetime(2014, 11, 5, 20, 34, 37)
-        TIME_DELETED = TIMESTAMP.isoformat() + '.000Z'
+        TIME_DELETED = TIMESTAMP.strftime(_RFC3339_MICROS)
         properties = {'timeDeleted': TIME_DELETED}
         blob = self._makeOne(BLOB_NAME, bucket=bucket, properties=properties)
         self.assertEqual(blob.time_deleted, TIMESTAMP)
@@ -1057,11 +1058,12 @@ def test_time_deleted_unset(self):
 
     def test_updated(self):
         import datetime
+        from gcloud._helpers import _RFC3339_MICROS
         BLOB_NAME = 'blob-name'
         connection = _Connection()
         bucket = _Bucket(connection)
         TIMESTAMP = datetime.datetime(2014, 11, 5, 20, 34, 37)
-        UPDATED = TIMESTAMP.isoformat() + '.000Z'
+        UPDATED = TIMESTAMP.strftime(_RFC3339_MICROS)
         properties = {'updated': UPDATED}
         blob = self._makeOne(BLOB_NAME, bucket=bucket, properties=properties)
         self.assertEqual(blob.updated, TIMESTAMP)

gcloud/storage/test_bucket.py

@@ -857,8 +857,9 @@ def test_storage_class(self):
 
     def test_time_created(self):
         import datetime
+        from gcloud._helpers import _RFC3339_MICROS
         TIMESTAMP = datetime.datetime(2014, 11, 5, 20, 34, 37)
-        TIME_CREATED = TIMESTAMP.isoformat() + '.000Z'
+        TIME_CREATED = TIMESTAMP.strftime(_RFC3339_MICROS)
         properties = {'timeCreated': TIME_CREATED}
         bucket = self._makeOne(properties=properties)
         self.assertEqual(bucket.time_created, TIMESTAMP)